Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
raftstore: add commit log duration metrics #5440
What have you changed?
add commit log duration metrics which spans from propose to committed
What is the type of the changes?
How is the PR tested?
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
Does this PR affect
@@ Benchmark Diff @@ ================================================================================ tidb: 0f2434660c509ec0b493d8c7ee0bbbf8e8549184 --- tikv: ff82aa9eba331585aec1c6cdf9e1584512bccb34 +++ tikv: 8ffba0e492bc24765a59eafb60eff83785ca8954 pd: ce060a9aeb66d6bbb39159243b879740dffae041 ================================================================================ test-1: < oltp_insert > * QPS : 21368.48 ± 0.3703% (std=62.71) delta: 1.39% * AvgMs : 11.97 ± 0.3550% (std=0.03) delta: -1.38% * PercentileMs99 : 42.92 ± 1.0903% (std=0.38) delta: 0.00% test-2: < oltp_update_non_index > * QPS : 29554.87 ± 0.2551% (std=50.41) delta: 0.01% * AvgMs : 8.66 ± 0.2541% (std=0.02) delta: 0.00% * PercentileMs99 : 30.59 ± 1.0788% (std=0.27) delta: -0.01% test-3: < oltp_read_write > * QPS : 36978.99 ± 0.3229% (std=71.08) delta: 0.15% * AvgMs : 138.99 ± 0.2979% (std=0.25) delta: -0.15% * PercentileMs99 : 257.95 ± 0.0000% (std=0.00) delta: 0.00% test-4: < oltp_point_select > * QPS : 75282.48 ± 1.4787% (std=730.39) delta: 1.39% * AvgMs : 3.40 ± 1.4706% (std=0.03) delta: -1.39% * PercentileMs99 : 7.43 ± 0.0000% (std=0.00) delta: -1.72% test-5: < oltp_update_index > * QPS : 16938.31 ± 0.0801% (std=9.59) delta: 1.07% * AvgMs : 15.11 ± 0.0794% (std=0.01) delta: -1.06% * PercentileMs99 : 48.34 ± 0.0000% (std=0.00) delta: 0.00%
sre-bot merged commit
Sep 11, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.Details
idc-jenkins-ci-tikv/integration-cop-push-down-test Jenkins job succeeded.Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.Details
idc-jenkins-ci/test Jenkins job succeeded.Details
This was referenced
Nov 13, 2019
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.