Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: prune deps #5454

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@nrc
Copy link
Contributor

nrc commented Sep 11, 2019

What have you changed?

Removed as many duplicate deps as currently possible (there is still some duplication, but none that are possible to resolve without multiple upstream changes).

This PR takes us from 367 to 327 deps (an 11% improvement). We currently have 5 known security vulnerabilities in our deps (according to cargo audit), this PR resolves all of them. This PR also improves compile times: a release build on my MacBook goes from 11:23 to 10:43 (an improvement of 6%). And of course gets us more recent versions of many dependencies.

What is the type of the changes?

Pick one of the following and delete the others:

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How is the PR tested?

Existing tests. Measured compile time.

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No

Does this PR affect tidb-ansible?

No

PTAL @zhangjinpeng1987 @overvenus

@nrc nrc requested review from overvenus and zhangjinpeng1987 Sep 11, 2019
@nrc nrc force-pushed the nrc:deps branch from 6bbb08d to 552ba79 Sep 11, 2019
Signed-off-by: Nick Cameron <nrc@ncameron.org>
@nrc nrc force-pushed the nrc:deps branch from 552ba79 to dfc47d3 Sep 11, 2019
@@ -215,7 +215,6 @@ clippy: pre-clippy
-A clippy::excessive_precision -A clippy::collapsible_if -A clippy::blacklisted_name \
-A clippy::needless_range_loop -A clippy::redundant_closure \
-A clippy::match_wild_err_arm -A clippy::blacklisted_name -A clippy::redundant_closure_call

This comment has been minimized.

Copy link
@Hoverbear

Hoverbear Sep 11, 2019

Member

Unrelated change?

@siddontang

This comment has been minimized.

Copy link
Contributor

siddontang commented Sep 12, 2019

Great

CI failed

@nrc

This comment has been minimized.

Copy link
Contributor Author

nrc commented Sep 12, 2019

/test

Copy link
Member

Hoverbear left a comment

LGTM

@overvenus

This comment has been minimized.

Copy link
Contributor

overvenus commented Sep 12, 2019

/run-all-tests

Copy link
Contributor

overvenus left a comment

LGTM, thank you!

@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Sep 12, 2019

/run-all-tests

@sre-bot sre-bot merged commit c9e6f2e into tikv:master Sep 12, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-cop-push-down-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@overvenus

This comment has been minimized.

Copy link
Contributor

overvenus commented Sep 12, 2019

/bench

sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.