Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support batch split region command and empty batch command #5470

Merged
merged 5 commits into from Sep 18, 2019

Conversation

@disksing
Copy link
Collaborator

commented Sep 17, 2019

What have you changed?

Cherry-pick #5001 #5268 #5466

What is the type of the changes?

  • Improvement (a change which is an improvement to an existing feature)

How is the PR tested?

unit-tests

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

NOTE: Does not support new TiDB run with old TiKV. For example, TiDB v3.0.4 + TiKV v3.0.0.

Does this PR affect tidb-ansible?

If there is a configuration or metrics change, please file a PR in tidb-ansible, and add the PR number here.

Refer to a related PR or issue link (optional)

#5001 #5268 #5466

Benchmark result if necessary (optional)

None

Any examples? (optional)

None

Signed-off-by: disksing <i@disksing.com>
@disksing disksing requested review from AndreMouche, overvenus and hicqu Sep 17, 2019
disksing and others added 3 commits Aug 22, 2019
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
* server/service: adapt unordered split keys

Signed-off-by: disksing <i@disksing.com>
@disksing disksing force-pushed the disksing:cherry branch from 62efad8 to 05a3476 Sep 17, 2019
@disksing

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 17, 2019

/run-all-tests

Copy link
Member

left a comment

LGTM

@AndreMouche

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

Could we use the tag NeedCherryPickxxx?

@disksing

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 17, 2019

@AndreMouche I don't think bot can properly handle it because it depends on another kvproto branch.

@hicqu
hicqu approved these changes Sep 18, 2019
@disksing disksing merged commit a99c22d into tikv:release-3.0 Sep 18, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-cop-push-down-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@disksing disksing deleted the disksing:cherry branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.