Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd, backup: enable backup feature #5476

Merged
merged 4 commits into from Sep 18, 2019

Conversation

@overvenus
Copy link
Contributor

overvenus commented Sep 17, 2019

What have you changed?

This PR enables the backup feature, removes unused imports and limits backup threads.

What is the type of the changes?

  • Improvement (a change which is an improvement to an existing feature)

How is the PR tested?

Integration tests.

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No.

Does this PR affect tidb-ansible?

No.

overvenus added 3 commits Sep 5, 2019
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus requested review from 5kbpers and NingLin-P Sep 17, 2019
Copy link
Contributor

NingLin-P left a comment

LGTM

@5kbpers 5kbpers added the S: CanMerge label Sep 18, 2019
@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Sep 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit e75aed8 into tikv:master Sep 18, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-cop-push-down-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@overvenus overvenus deleted the overvenus:backup/enable branch Sep 20, 2019
overvenus added a commit to overvenus/tikv that referenced this pull request Sep 25, 2019
Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit that referenced this pull request Sep 26, 2019
* backup: add backup component and error type (#5352)

Signed-off-by: Neil Shen <overvenus@gmail.com>

* backup: add BackupWriter which converts txn entries to sst files (#5358)

Signed-off-by: Neil Shen <overvenus@gmail.com>

* backup: add backup service (#5359)

Signed-off-by: Neil Shen <overvenus@gmail.com>

* backup: add backup endpoint (#5392)

Signed-off-by: Neil Shen <overvenus@gmail.com>

* backup: record errors to metrics (#5436)

Signed-off-by: Neil Shen <overvenus@gmail.com>

* backup: support backup with rate limit (#5451)

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cmd, backup: enable backup feature (#5476)

Signed-off-by: Neil Shen <overvenus@gmail.com>
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.