Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor: use BufferWriter for tidb_query component #5496

Merged
merged 2 commits into from Sep 23, 2019

Conversation

@niedhui
Copy link
Collaborator

niedhui commented Sep 22, 2019

Signed-off-by: niedhui niedhui@gmail.com

What have you changed?

This PR change all the encode part using codec::BufferWriter. parts of issue #4040

What is the type of the changes?

Engineering

How is the PR tested?

unit test (make expression)

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No

Does this PR affect tidb-ansible?

No

Refer to a related PR or issue link (optional)

#4040

Signed-off-by: niedhui <niedhui@gmail.com>
@breeswish

This comment has been minimized.

Copy link
Member

breeswish commented Sep 22, 2019

Thanks!

Copy link
Contributor

sticnarf left a comment

LGTM

@sticnarf

This comment has been minimized.

Copy link
Contributor

sticnarf commented Sep 23, 2019

/ok-to-test

@iosmanthus

This comment has been minimized.

Copy link
Contributor

iosmanthus commented Sep 23, 2019

/run-all-test

@iosmanthus iosmanthus added the C: Copr label Sep 23, 2019
@sticnarf

This comment has been minimized.

Copy link
Contributor

sticnarf commented Sep 23, 2019

/merge

@sre-bot sre-bot added the S: CanMerge label Sep 23, 2019
@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Sep 23, 2019

/run-all-tests

@sre-bot sre-bot merged commit c142fa8 into tikv:master Sep 23, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-cop-push-down-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.