Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output on short version flag (#5348) #5501

Merged
merged 1 commit into from Sep 24, 2019

Conversation

@lucklove
Copy link
Member

commented Sep 23, 2019

Keep -V behavior same with v2.x

Signed-off-by: lucklove gnu.crazier@gmail.com

What have you changed?

The -V output format of tikv-server and tikv-ctl.
The output of -V in v2.x is something like:

TiKV
Release Version: 2.1.14
Git Commit Hash: 32ca82bc067f7529dc07bf8ddb594b8c060b7f49
Git Commit Branch: HEAD
UTC Build Time: 2019-07-04 10:32:40
Rust Version: rustc 1.29.0-nightly (4f3c7a472 2018-07-17)

However, in v3.x, it's something like:

TiKV 3.0.2

And in the newest master, it's:

TiKV 0.0.1

We should keep the output format same with v2.x, because the tidb and pd's output format is that. I think they should have a unified behavior.

What is the type of the changes?

  • Bugfix (a change which fixes an issue)

How is the PR tested?

manual test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No

Does this PR affect tidb-ansible?

No

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Any examples? (optional)

Signed-off-by: lucklove <gnu.crazier@gmail.com>
Copy link
Member

left a comment

LGTM

@you06
you06 approved these changes Sep 23, 2019
Copy link
Contributor

left a comment

LGTM

@lucklove

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2019

/run-all-tests

@lucklove lucklove merged commit bff6c34 into release-3.0 Sep 24, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-cop-push-down-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.