Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-rocksdb #5805

Closed
wants to merge 1 commit into from

Conversation

@brson
Copy link
Contributor

brson commented Nov 4, 2019

What have you changed?

This updates rust-rocksdb to the latest master, to pull in tikv/rust-rocksdb#372, which adds reference-counted SST reader iterators, which is needed by #5790, which abstracts the SST reader under engine_traits.

This also pulls in a few other rust-rocksdb changes:

66e0f31 titan: Revert "Relax warnings as errors so we can build on Clang 11 (#90)" (#102) (#374)
2051188 titan: Revert wait for flush before GC (#103) (#373)
64bf468 Add Rc-based SstFileReader iterators (#372)
531392a titan: Implement basic range merge to maintain last level sorted run number (#92) (#371)
a0b5763 add update rocksdb script (#370)
4fa9a0c titan: Add log for blob file range (#101) (#368)
4ed8b94 git submodule when init (#366)
019e91b remove update_titan feature (#365)
9178596 fix misspelling in README.md (#358)

What is the type of the changes?

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How is the PR tested?

cargo test --all --no-run

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

no

Does this PR affect tidb-ansible?

no

Refer to a related PR or issue link (optional)

#4184

Benchmark result if necessary (optional)

Any examples? (optional)

Signed-off-by: Brian Anderson <andersrb@gmail.com>
@5kbpers
5kbpers approved these changes Nov 4, 2019
Copy link
Contributor

5kbpers left a comment

LGTM

Copy link
Contributor

yiwu-arbug left a comment

LGTM

@yiwu-arbug

This comment has been minimized.

Copy link
Contributor

yiwu-arbug commented Nov 4, 2019

/run-all-tests

Copy link
Contributor

yiwu-arbug left a comment

Just realize rocksdb repo is not up-to-date to include a titan fix. Will update it.

@yiwu-arbug

This comment has been minimized.

Copy link
Contributor

yiwu-arbug commented Nov 4, 2019

@brson mind approve tikv/rust-rocksdb#376 and update accordingly? Thanks.

@Connor1996

This comment has been minimized.

Copy link
Member

Connor1996 commented Nov 5, 2019

This update falls a little behind with the latest rust-rocksdb, and the bot will take care of updating rust-rocksdb #5808, so close it and merge the newer PR.

@Connor1996 Connor1996 closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.