Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring txn: restrict the API of storage #5964

Merged
merged 10 commits into from Dec 3, 2019
Merged

Refactoring txn: restrict the API of storage #5964

merged 10 commits into from Dec 3, 2019

Conversation

@nrc
Copy link
Contributor

nrc commented Nov 19, 2019

What have you changed?

This PR attempts to shrink the public interface of the storage module and re-export less. This PR also makes naming a little more idiomatic, e.g., by changing GC to Gc.

PTAL @MyonKeminta @sticnarf

What is the type of the changes?

  • Engineering (engineering change which doesn't change any feature or fix any issue)
@nrc nrc force-pushed the nrc:refactor5 branch from ca67ce5 to a511297 Nov 19, 2019
@nrc nrc requested review from MyonKeminta and sticnarf Nov 20, 2019
@MyonKeminta

This comment has been minimized.

Copy link
Contributor

MyonKeminta commented Nov 20, 2019

@overvenus This PR moves some code related to raftstore. I think you can take a look about whether this change is ok. Thanks!

@@ -19,14 +19,14 @@ use kvproto::metapb;
use log_wrappers::DisplayValue;

This comment has been minimized.

Copy link
@MyonKeminta

MyonKeminta Nov 20, 2019

Contributor

No we've worked hard to move gc_worker out of storage, so that raftstore and some other things won't be storage's dependency. It shouldn't be moved back.

This comment has been minimized.

Copy link
@nrc

nrc Nov 20, 2019

Author Contributor

That's a shame. My goal here is to avoid making storage::metrics public. Could gc_workeruse different metrics? Or none at all? If it cannot, then I think it is part of storage.

Another approach would be to move the metrics out of the modules and into their own directory, but that was not popular when I suggested it.

This comment has been minimized.

Copy link
@MyonKeminta

MyonKeminta Nov 20, 2019

Contributor

I think most metrics of gc_worker's metrics can be moved out from storage, and put together with gc_worker (although it may contains "storage" word). But I'm not sure if there is any metrics can't be moved. I think you can have a try.

This comment has been minimized.

Copy link
@nrc

nrc Nov 25, 2019

Author Contributor

I've removed this change and instead moved the GC metrics to server. @MyonKeminta PTAL

@nrc nrc force-pushed the nrc:refactor5 branch 4 times, most recently from 0cf7edc to b74c52e Nov 24, 2019
@nrc nrc requested a review from overvenus Nov 27, 2019
Copy link
Contributor

overvenus left a comment

Raftstore part is LGTM, the only concern is name collision, RaftRouter, RaftStoreRouter and ServerRaftStoreRouter , it's hard to tell what's the difference between them. Maybe we need to give them better names.

@nrc

This comment has been minimized.

Copy link
Contributor Author

nrc commented Nov 27, 2019

RaftRouter, RaftStoreRouter and ServerRaftStoreRouter ,

Yeah, I thought that too. I don't think this PR makes the situation worse. I didn't want to rename here since I wasn't 100% clear on their roles so don't know good names.

@nrc nrc force-pushed the nrc:refactor5 branch from b74c52e to 5ca7890 Nov 27, 2019
@nrc

This comment has been minimized.

Copy link
Contributor Author

nrc commented Nov 27, 2019

/merge

@sre-bot sre-bot added the S: CanMerge label Nov 27, 2019
@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Nov 27, 2019

/run-all-tests

@nrc

This comment has been minimized.

Copy link
Contributor Author

nrc commented Nov 27, 2019

Whoops, wrong PR.

@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Nov 27, 2019

@nrc merge failed.

@nrc nrc force-pushed the nrc:refactor5 branch from 2cd658b to 98559d1 Nov 27, 2019
@nrc nrc force-pushed the nrc:refactor5 branch from 749ca47 to ceb0551 Nov 28, 2019
Copy link
Member

AndreMouche left a comment

LGTM

@@ -869,9 +866,9 @@ mod tests {
// should read pending locks
must_get_err(&engine, k1, 7);
// should ignore the primary lock and get none when reading the latest record
must_get_none(&engine, k1, u64::MAX);

This comment has been minimized.

Copy link
@sticnarf

sticnarf Nov 28, 2019

Contributor

Just for curiosity, are module level constants like this deprecated after corresponding const fns are supported?

This comment has been minimized.

Copy link
@nrc

nrc Nov 28, 2019

Author Contributor

I don't think they are explicitly deprecated (yet), but there is no point in using them over a const fn

@nrc nrc force-pushed the nrc:refactor5 branch from 9a3b372 to b370617 Nov 28, 2019
@nrc

This comment has been minimized.

Copy link
Contributor Author

nrc commented Nov 28, 2019

@sticnarf @AndreMouche comments addressed, PTAL

Copy link
Contributor

sticnarf left a comment

LGTM. Do you have something more to comment? @MyonKeminta @youjiali1995

@nrc nrc force-pushed the nrc:refactor5 branch from b370617 to 5c8117b Nov 29, 2019
Copy link
Contributor

MyonKeminta left a comment

Mostly LGTM

src/server/gc_worker.rs Outdated Show resolved Hide resolved
nrc added 9 commits Nov 19, 2019
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
@nrc nrc force-pushed the nrc:refactor5 branch from 98a6d8e to c4a56ca Dec 2, 2019
Signed-off-by: Nick Cameron <nrc@ncameron.org>
@nrc nrc force-pushed the nrc:refactor5 branch from c4a56ca to 8611481 Dec 2, 2019
Copy link
Contributor

MyonKeminta left a comment

LGTM

@nrc

This comment has been minimized.

Copy link
Contributor Author

nrc commented Dec 3, 2019

/merge

@sre-bot sre-bot added the S: CanMerge label Dec 3, 2019
@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Dec 3, 2019

/run-all-tests

@sre-bot sre-bot merged commit 1674fd0 into tikv:master Dec 3, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-copr-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
tw666 added a commit to tw666/tikv that referenced this pull request Dec 3, 2019
commit 9fcc672
Merge: 43ecfab 55909d0
Author: 魂锁典狱长 <t888y@qq.com>
Date:   Tue Dec 3 18:07:02 2019 +0800

    Merge branch 'master' into month_name

    Signed-off-by: tw <t888y@qq.com>

commit 55909d0
Author: Wenxuan <breezewish@pingcap.com>
Date:   Tue Dec 3 15:02:42 2019 +0800

    Switch to use static metrics for Coprocessor Runner (tikv#6134)

    Signed-off-by: Breezewish <breezewish@pingcap.com>

commit 1674fd0
Author: Nick Cameron <nrc@ncameron.org>
Date:   Tue Dec 3 18:04:56 2019 +1300

    Refactoring txn: restrict the API of storage (tikv#5964)

    Signed-off-by: Nick Cameron <nrc@ncameron.org>

commit 43ecfab
Merge: c05eb8a 95ad796
Author: tw <t888y@qq.com>
Date:   Mon Dec 2 16:26:47 2019 +0800

    Merge remote-tracking branch 'upstream/master' into month_name

    # Conflicts:
    #	components/tidb_query/src/rpn_expr/impl_time.rs

commit c05eb8a
Author: tw <t888y@qq.com>
Date:   Mon Dec 2 16:21:21 2019 +0800

    add MonthExtension

    Signed-off-by: tw <t888y@qq.com>

commit 95ad796
Author: Lei Zhao <zlwgx1023@gmail.com>
Date:   Mon Dec 2 14:06:54 2019 +0800

    deadlock: only observe valid region (tikv#6125)

    Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

commit dfd6a80
Author: Wenxuan <breezewish@pingcap.com>
Date:   Mon Dec 2 13:53:29 2019 +0800

    Support StartTs in Coprocessor.Request (tikv#6127)

    Signed-off-by: Breezewish <breezewish@pingcap.com>

commit 8e9aa21
Author: Iosmanthus Teng <MyOsmanthusTree@gmail.com>
Date:   Mon Dec 2 13:27:19 2019 +0800

    Copr: add cast_*_as_time (tikv#6057)

    Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>

commit 983c626
Author: Wenxuan <breezewish@pingcap.com>
Date:   Mon Dec 2 11:22:02 2019 +0800

    Always collect execution summary for BatchExecutor (tikv#6112)

    Signed-off-by: Breezewish <breezewish@pingcap.com>

commit 9b3509f
Author: Zhongyang Wu <zhongyang.wu@outlook.com>
Date:   Sun Dec 1 22:05:23 2019 -0500

    copr: vectorize is_ipv4_mapped (tikv#6025)

    Signed-off-by: zhongyang.wu <zhongyang.wu@outlook.com>

commit b23731b
Author: Zhu Zihao <all_but_last@163.com>
Date:   Mon Dec 2 10:33:53 2019 +0800

    copr: Vectorize `uncompressed_length`. (tikv#6109)

    Signed-off-by: Zhu Zihao <all_but_last@163.com>

commit 15f9af9
Author: Qinxuan Chen <koushiro.cqx@gmail.com>
Date:   Sat Nov 30 12:14:23 2019 +0800

    copr: vectorize md5 (tikv#6091)

    Signed-off-by: koushiro <koushiro.cqx@gmail.com>

commit e862ba3
Author: FateTHarlaown <623239185@qq.com>
Date:   Sat Nov 30 11:49:23 2019 +0800

    copr: Add vectorize day_of_month (tikv#6103)

    Signed-off-by: FateTHarlaown <623239185@qq.com>

commit 5e279c5
Author: Weizhen Wang <hawking.rei@gmail.com>
Date:   Sat Nov 30 09:50:54 2019 +0800

    copr/mysql/json: support json_depth (tikv#5924)

    Signed-off-by: Wangweizhen <hawking.rei@gmail.com>

commit 2138acd
Author: Ana Hobden <operator@hoverbear.org>
Date:   Fri Nov 29 10:24:52 2019 -0800

    Simplify the Dockerfile (tikv#6081)

    Signed-off-by: Ana Hobden <operator@hoverbear.org>

commit dd63b75
Merge: 694061c 30649d7
Author: tw <t888y@qq.com>
Date:   Fri Nov 29 20:56:08 2019 +0800

    Merge branch 'month_name' of https://github.com/tw666/tikv into month_name

commit 694061c
Author: tw <t888y@qq.com>
Date:   Fri Nov 29 20:55:32 2019 +0800

    remove format

    Signed-off-by: tw <t888y@qq.com>

commit cd87848
Author: 庄天翼 <zty0826@gmail.com>
Date:   Fri Nov 29 13:01:24 2019 +0800

    copr: add more assert in compare_in test (tikv#6098)

    Signed-off-by: TennyZhuang <zty0826@gmail.com>

commit 30649d7
Author: 魂锁典狱长 <t888y@qq.com>
Date:   Fri Nov 29 12:00:10 2019 +0800

    Update components/tidb_query/src/rpn_expr/impl_time.rs

    Co-Authored-By: disksing <i@disksing.com>

commit f6869af
Author: pingcap-github-bot <sre-bot@pingcap.com>
Date:   Fri Nov 29 11:06:25 2019 +0800

    rust-rocksdb: Fix clippy warnings etc. (tikv#6080)

    Signed-off-by: sre-bot <sre-bot@pingcap.com>

commit 157f672
Author: TY <t1997y@vip.qq.com>
Date:   Fri Nov 29 10:52:25 2019 +0800

    copr: Add vectorize FieldInt/FieldReal/FieldString (tikv#6086)

    Signed-off-by: taoyu <t1997y@vip.qq.com>

commit b10c87a
Merge: 276d543 35b5038
Author: tw <t888y@qq.com>
Date:   Fri Nov 29 10:23:48 2019 +0800

    Merge branch 'month_name' of https://github.com/tw666/tikv into month_name

commit 276d543
Author: tw <t888y@qq.com>
Date:   Fri Nov 29 10:22:59 2019 +0800

    case for SqlMode::NO_ZERO_DATE

    Signed-off-by: tw <t888y@qq.com>

commit 48c17fb
Author: niedhui <niedhui@gmail.com>
Date:   Fri Nov 29 10:08:23 2019 +0800

    fix cargo build (tikv#6100)

    Signed-off-by: niedhui <niedhui@gmail.com>

commit 926a227
Author: Nick Cameron <nrc@ncameron.org>
Date:   Fri Nov 29 14:43:40 2019 +1300

    Fix a failing test due to recursion limit (tikv#6102)

    Signed-off-by: Nick Cameron <nrc@ncameron.org>

commit e9e578f
Author: Wenxuan <breezewish@pingcap.com>
Date:   Thu Nov 28 20:02:52 2019 +0800

    Fix the bug that IN() optimization is not taking effect (tikv#6093)

    Signed-off-by: Breezewish <breezewish@pingcap.com>

commit bdc0ccf
Author: Wenxuan <breezewish@pingcap.com>
Date:   Thu Nov 28 19:19:24 2019 +0800

    Support skip cached Coprocessor request (tikv#6076)

    Signed-off-by: Breezewish <breezewish@pingcap.com>

commit 0609915
Author: Huang Zexin <hzx20112012@gmail.com>
Date:   Thu Nov 28 17:00:54 2019 +0800

    tidb_query: refactor utility functions of `rpn_expr::impl_cast::tests` module (tikv#6060)

    Signed-off-by: H-ZeX <hzx20112012@gmail.com>

commit 61af99d
Author: Shenghui Wu <793703860@qq.com>
Date:   Thu Nov 28 16:19:55 2019 +0800

    expression: add missing scalar function signature (tikv#6082)

    Signed-off-by: wshwsh12 <793703860@qq.com>

commit dc758d6
Author: 3pointer <luancheng@pingcap.com>
Date:   Thu Nov 28 16:07:54 2019 +0800

    backup: put startKey into backup_file_name to make it unique (tikv#6071)

    Signed-off-by: luancheng <luancheng@pingcap.com>

commit d03a6a7
Author: Weizhen Wang <hawking.rei@gmail.com>
Date:   Thu Nov 28 15:14:55 2019 +0800

    copr/mysql/json: support json_keys (tikv#5931)

    Signed-off-by: Wangweizhen <hawking.rei@gmail.com>

commit 35b5038
Merge: 597cc15 982f144
Author: Nick Cameron <nrc@ncameron.org>
Date:   Thu Nov 28 19:06:12 2019 +1300

    Merge branch 'master' into month_name

commit 597cc15
Author: tw <t888y@qq.com>
Date:   Thu Nov 28 12:33:13 2019 +0800

    copr: Add vectorize month_name

    Signed-off-by: tw <t888y@qq.com>

Signed-off-by: tw <t888y@qq.com>
tw666 added a commit to tw666/tikv that referenced this pull request Dec 3, 2019
commit 9fcc672
Merge: 43ecfab 55909d0
Author: 魂锁典狱长 <t888y@qq.com>
Date:   Tue Dec 3 18:07:02 2019 +0800

    Merge branch 'master' into month_name

    Signed-off-by: tw <t888y@qq.com>

commit 55909d0
Author: Wenxuan <breezewish@pingcap.com>
Date:   Tue Dec 3 15:02:42 2019 +0800

    Switch to use static metrics for Coprocessor Runner (tikv#6134)

    Signed-off-by: Breezewish <breezewish@pingcap.com>

commit 1674fd0
Author: Nick Cameron <nrc@ncameron.org>
Date:   Tue Dec 3 18:04:56 2019 +1300

    Refactoring txn: restrict the API of storage (tikv#5964)

    Signed-off-by: Nick Cameron <nrc@ncameron.org>

commit 43ecfab
Merge: c05eb8a 95ad796
Author: tw <t888y@qq.com>
Date:   Mon Dec 2 16:26:47 2019 +0800

    Merge remote-tracking branch 'upstream/master' into month_name

    # Conflicts:
    #	components/tidb_query/src/rpn_expr/impl_time.rs

commit c05eb8a
Author: tw <t888y@qq.com>
Date:   Mon Dec 2 16:21:21 2019 +0800

    add MonthExtension

    Signed-off-by: tw <t888y@qq.com>

commit 95ad796
Author: Lei Zhao <zlwgx1023@gmail.com>
Date:   Mon Dec 2 14:06:54 2019 +0800

    deadlock: only observe valid region (tikv#6125)

    Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

commit dfd6a80
Author: Wenxuan <breezewish@pingcap.com>
Date:   Mon Dec 2 13:53:29 2019 +0800

    Support StartTs in Coprocessor.Request (tikv#6127)

    Signed-off-by: Breezewish <breezewish@pingcap.com>

commit 8e9aa21
Author: Iosmanthus Teng <MyOsmanthusTree@gmail.com>
Date:   Mon Dec 2 13:27:19 2019 +0800

    Copr: add cast_*_as_time (tikv#6057)

    Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>

commit 983c626
Author: Wenxuan <breezewish@pingcap.com>
Date:   Mon Dec 2 11:22:02 2019 +0800

    Always collect execution summary for BatchExecutor (tikv#6112)

    Signed-off-by: Breezewish <breezewish@pingcap.com>

commit 9b3509f
Author: Zhongyang Wu <zhongyang.wu@outlook.com>
Date:   Sun Dec 1 22:05:23 2019 -0500

    copr: vectorize is_ipv4_mapped (tikv#6025)

    Signed-off-by: zhongyang.wu <zhongyang.wu@outlook.com>

commit b23731b
Author: Zhu Zihao <all_but_last@163.com>
Date:   Mon Dec 2 10:33:53 2019 +0800

    copr: Vectorize `uncompressed_length`. (tikv#6109)

    Signed-off-by: Zhu Zihao <all_but_last@163.com>

commit 15f9af9
Author: Qinxuan Chen <koushiro.cqx@gmail.com>
Date:   Sat Nov 30 12:14:23 2019 +0800

    copr: vectorize md5 (tikv#6091)

    Signed-off-by: koushiro <koushiro.cqx@gmail.com>

commit e862ba3
Author: FateTHarlaown <623239185@qq.com>
Date:   Sat Nov 30 11:49:23 2019 +0800

    copr: Add vectorize day_of_month (tikv#6103)

    Signed-off-by: FateTHarlaown <623239185@qq.com>

commit 5e279c5
Author: Weizhen Wang <hawking.rei@gmail.com>
Date:   Sat Nov 30 09:50:54 2019 +0800

    copr/mysql/json: support json_depth (tikv#5924)

    Signed-off-by: Wangweizhen <hawking.rei@gmail.com>

commit 2138acd
Author: Ana Hobden <operator@hoverbear.org>
Date:   Fri Nov 29 10:24:52 2019 -0800

    Simplify the Dockerfile (tikv#6081)

    Signed-off-by: Ana Hobden <operator@hoverbear.org>

commit dd63b75
Merge: 694061c 30649d7
Author: tw <t888y@qq.com>
Date:   Fri Nov 29 20:56:08 2019 +0800

    Merge branch 'month_name' of https://github.com/tw666/tikv into month_name

commit 694061c
Author: tw <t888y@qq.com>
Date:   Fri Nov 29 20:55:32 2019 +0800

    remove format

    Signed-off-by: tw <t888y@qq.com>

commit cd87848
Author: 庄天翼 <zty0826@gmail.com>
Date:   Fri Nov 29 13:01:24 2019 +0800

    copr: add more assert in compare_in test (tikv#6098)

    Signed-off-by: TennyZhuang <zty0826@gmail.com>

commit 30649d7
Author: 魂锁典狱长 <t888y@qq.com>
Date:   Fri Nov 29 12:00:10 2019 +0800

    Update components/tidb_query/src/rpn_expr/impl_time.rs

    Co-Authored-By: disksing <i@disksing.com>

commit f6869af
Author: pingcap-github-bot <sre-bot@pingcap.com>
Date:   Fri Nov 29 11:06:25 2019 +0800

    rust-rocksdb: Fix clippy warnings etc. (tikv#6080)

    Signed-off-by: sre-bot <sre-bot@pingcap.com>

commit 157f672
Author: TY <t1997y@vip.qq.com>
Date:   Fri Nov 29 10:52:25 2019 +0800

    copr: Add vectorize FieldInt/FieldReal/FieldString (tikv#6086)

    Signed-off-by: taoyu <t1997y@vip.qq.com>

commit b10c87a
Merge: 276d543 35b5038
Author: tw <t888y@qq.com>
Date:   Fri Nov 29 10:23:48 2019 +0800

    Merge branch 'month_name' of https://github.com/tw666/tikv into month_name

commit 276d543
Author: tw <t888y@qq.com>
Date:   Fri Nov 29 10:22:59 2019 +0800

    case for SqlMode::NO_ZERO_DATE

    Signed-off-by: tw <t888y@qq.com>

commit 48c17fb
Author: niedhui <niedhui@gmail.com>
Date:   Fri Nov 29 10:08:23 2019 +0800

    fix cargo build (tikv#6100)

    Signed-off-by: niedhui <niedhui@gmail.com>

commit 926a227
Author: Nick Cameron <nrc@ncameron.org>
Date:   Fri Nov 29 14:43:40 2019 +1300

    Fix a failing test due to recursion limit (tikv#6102)

    Signed-off-by: Nick Cameron <nrc@ncameron.org>

commit e9e578f
Author: Wenxuan <breezewish@pingcap.com>
Date:   Thu Nov 28 20:02:52 2019 +0800

    Fix the bug that IN() optimization is not taking effect (tikv#6093)

    Signed-off-by: Breezewish <breezewish@pingcap.com>

commit bdc0ccf
Author: Wenxuan <breezewish@pingcap.com>
Date:   Thu Nov 28 19:19:24 2019 +0800

    Support skip cached Coprocessor request (tikv#6076)

    Signed-off-by: Breezewish <breezewish@pingcap.com>

commit 0609915
Author: Huang Zexin <hzx20112012@gmail.com>
Date:   Thu Nov 28 17:00:54 2019 +0800

    tidb_query: refactor utility functions of `rpn_expr::impl_cast::tests` module (tikv#6060)

    Signed-off-by: H-ZeX <hzx20112012@gmail.com>

commit 61af99d
Author: Shenghui Wu <793703860@qq.com>
Date:   Thu Nov 28 16:19:55 2019 +0800

    expression: add missing scalar function signature (tikv#6082)

    Signed-off-by: wshwsh12 <793703860@qq.com>

commit dc758d6
Author: 3pointer <luancheng@pingcap.com>
Date:   Thu Nov 28 16:07:54 2019 +0800

    backup: put startKey into backup_file_name to make it unique (tikv#6071)

    Signed-off-by: luancheng <luancheng@pingcap.com>

commit d03a6a7
Author: Weizhen Wang <hawking.rei@gmail.com>
Date:   Thu Nov 28 15:14:55 2019 +0800

    copr/mysql/json: support json_keys (tikv#5931)

    Signed-off-by: Wangweizhen <hawking.rei@gmail.com>

commit 35b5038
Merge: 597cc15 982f144
Author: Nick Cameron <nrc@ncameron.org>
Date:   Thu Nov 28 19:06:12 2019 +1300

    Merge branch 'master' into month_name

commit 597cc15
Author: tw <t888y@qq.com>
Date:   Thu Nov 28 12:33:13 2019 +0800

    copr: Add vectorize month_name

    Signed-off-by: tw <t888y@qq.com>

Signed-off-by: tw <t888y@qq.com>
zhang555 added a commit to zhang555/tikv that referenced this pull request Dec 16, 2019
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.