Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: Print sst files in region properties #5987

Merged
merged 7 commits into from Nov 25, 2019
Merged

Conversation

@Connor1996
Copy link
Member

Connor1996 commented Nov 21, 2019

What have you changed?

Print SST files in region properties, which facilitates debugging.

What is the type of the changes?

  • Improvement (a change which is an improvement to an existing feature)

How is the PR tested?

  • Manual test (add detailed scripts or steps below)
    run the tikv-ctl region-properties command

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No

Does this PR affect tidb-ansible?

No

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Copy link
Member

zhangjinpeng1987 left a comment

LGTM

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Copy link
Contributor

yiwu-arbug left a comment

LGTM

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996 Connor1996 force-pushed the Connor1996:sst-files branch from c90ca29 to bdec1f6 Nov 21, 2019
@Connor1996

This comment has been minimized.

Copy link
Member Author

Connor1996 commented Nov 21, 2019

@brson
brson approved these changes Nov 21, 2019
@brson

This comment has been minimized.

Copy link
Contributor

brson commented Nov 21, 2019

lgtm

Copy link
Member

zhangjinpeng1987 left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Nov 25, 2019

/run-all-tests

@sre-bot sre-bot merged commit 815d096 into tikv:master Nov 25, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-copr-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
hawkingrei added a commit to hawkingrei/tikv that referenced this pull request Dec 1, 2019
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.