Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: implement Hash for Decimal and Time #6047

Merged
merged 5 commits into from Nov 26, 2019

Conversation

@TennyZhuang
Copy link
Contributor

TennyZhuang commented Nov 26, 2019

Signed-off-by: TennyZhuang zty0826@gmail.com

What have you changed?

Please explain in detail what the changes are in this PR and why they are needed:

  • Summarize your change
  • How does this PR work? Include a brief introduction for any changed logic (optional)
  • Separately describe each logical change (optional)
  • Describe any limitations of the current code (optional)

Don't assume reviewers understand the original issue.

What is the type of the changes?

Pick one of the following and delete the others:

implement Hash for Decimal and Time

How is the PR tested?

Please select the tests that you ran to verify your changes:

  • Unit test
  • Fuzz test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

Does this PR affect tidb-ansible?

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Any examples? (optional)

Signed-off-by: TennyZhuang <zty0826@gmail.com>
TennyZhuang added 3 commits Nov 26, 2019
Signed-off-by: TennyZhuang <zty0826@gmail.com>
fix
Signed-off-by: TennyZhuang <zty0826@gmail.com>
fix
Signed-off-by: TennyZhuang <zty0826@gmail.com>
@TennyZhuang TennyZhuang force-pushed the TennyZhuang:hash-decimal-time branch from 326b8a1 to 8840563 Nov 26, 2019
Copy link
Member

breeswish left a comment

Verified that the Hash implementation for Decimal passes fuzz test. Approve.

@breeswish

This comment has been minimized.

Copy link
Member

breeswish commented Nov 26, 2019

/merge

@sre-bot sre-bot added the S: CanMerge label Nov 26, 2019
@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Nov 26, 2019

Your auto merge job has been accepted, waiting for 6018, 6046, 6045

@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Nov 26, 2019

/run-all-tests

@sre-bot

This comment has been minimized.

Copy link
Collaborator

sre-bot commented Nov 26, 2019

@TennyZhuang merge failed.

@breeswish

This comment has been minimized.

Copy link
Member

breeswish commented Nov 26, 2019

/test

@breeswish breeswish merged commit 7120085 into tikv:master Nov 26, 2019
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-copr-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
hawkingrei added a commit to hawkingrei/tikv that referenced this pull request Dec 1, 2019
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.