Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upcop: change handle_request interface to async #6250
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
/release |
This comment has been minimized.
This comment has been minimized.
|
Nice clean up! Could you also change the streaming version to use async await as well? The rest LGTM. |
This comment has been minimized.
This comment has been minimized.
|
@breeswish Ok. I'll also do it for the streaming part. |
This comment has been minimized.
This comment has been minimized.
|
@breeswish I've changed the streaming part to async/await too. PTAL. |
|
Rest LGTM |
components/tikv_util/src/future.rs
Outdated
| @@ -20,6 +20,23 @@ where | |||
| (callback, future) | |||
| } | |||
|
|
|||
| pub fn paired_future_callback_new<T>() -> ( | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
/bench +sysbench +tpch |
|
Cool |
|
LGTM |
This comment has been minimized.
This comment has been minimized.
|
/merge |
This comment has been minimized.
This comment has been minimized.
|
/run-all-tests |
This comment has been minimized.
This comment has been minimized.
|
@sticnarf merge failed. |
This comment has been minimized.
This comment has been minimized.
|
/merge |
This comment has been minimized.
This comment has been minimized.
|
/run-all-tests |
This comment has been minimized.
This comment has been minimized.
|
/run-all-tests |
a426b3b
into
tikv:master
5 of 6 checks passed
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sticnarf commentedDec 16, 2019
•
edited
What have you changed?
This PR simplifies
handle_unary_request_implusing async/await. It also changeshandle_requestto an async function so that we may interrupt it in the future.Due to limitations of async/await and future compat layer, this PR introduces two more allocations. Benchmark shows there's no significant influence.
sysbench 32 tables x 1M rows
workload: read_only without point get (all requests are small coprocessor requests)
Master:
This PR:
What is the type of the changes?
How is the PR tested?
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Does this PR affect
tidb-ansible?No