backup raw kv for review #6261
Closed
backup raw kv for review #6261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xinhua5 <xinhua5@163.com>
xinhua5
force-pushed
the
pr_tikv_6213
branch
from
24ba0cb
to
1203061
Compare
MyonKeminta
reviewed
Dec 17, 2019
| @@ -97,6 +102,8 @@ impl Task { | |||
| storage, | |||
| concurrency: req.get_concurrency(), | |||
| cancel: cancel.clone(), | |||
| is_raw_kv: req.get_is_raw_kv(), | |||
| cf: req.get_cf().to_string(), | |||
There was a problem hiding this comment.
CI failed here. I think you didn't upgrade kvproto or didn't commit Cargo.lock. Please make sure you've run cargo update -p kvproto and commit the Cargo.lock file.
overvenus
added
the
component/backup-restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed?
Please explain in detail what the changes are in this PR and why they are needed:
Don't assume reviewers understand the original issue.
What is the type of the changes?
Pick one of the following and delete the others:
How is the PR tested?
Please select the tests that you ran to verify your changes:
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
Does this PR affect
tidb-ansible?If there is a configuration or metrics change, please file a PR in tidb-ansible, and add the PR number here.
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Any examples? (optional)