Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error handling about rocksdb iterator #6327

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@hicqu
Copy link
Contributor

hicqu commented Dec 24, 2019

What have you changed?

Fix error handling about rocksdb iterator.

What is the type of the changes?

Bug fix.

How is the PR tested?

Unit tests.

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No.

Does this PR affect tidb-ansible?

No.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Any examples? (optional)

@hicqu

This comment has been minimized.

Copy link
Contributor Author

hicqu commented Dec 24, 2019

/run-all-tests

Copy link
Member

Connor1996 left a comment

LGTM

Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu hicqu force-pushed the hicqu:release-2.1-qupeng branch from d623be3 to 96217be Dec 24, 2019
@hicqu

This comment has been minimized.

Copy link
Contributor Author

hicqu commented Dec 24, 2019

/run-all-tests

Copy link
Member

zhangjinpeng1987 left a comment

LGTM

Copy link
Member

Connor1996 left a comment

LGTM

@AndreMouche AndreMouche added this to the 2.1.20 milestone Dec 25, 2019
@hicqu hicqu dismissed stale reviews from Connor1996 and zhangjinpeng1987 via 970d264 Jan 10, 2020
@hicqu hicqu force-pushed the hicqu:release-2.1-qupeng branch 2 times, most recently from 970d264 to 96217be Jan 10, 2020
Copy link
Member

Connor1996 left a comment

LGTM

Copy link
Member

zhangjinpeng1987 left a comment

LGTM

@zhangjinpeng1987 zhangjinpeng1987 merged commit a26f1a1 into tikv:release-2.1 Jan 10, 2020
5 checks passed
5 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@hicqu hicqu deleted the hicqu:release-2.1-qupeng branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.