Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: support online change gc worker config #6359

Merged
merged 15 commits into from Jan 8, 2020

Conversation

@NingLin-P
Copy link
Contributor

NingLin-P commented Dec 28, 2019

What have you changed?

This pr is part of online config change.
This pr add support for online change gc worker config by using VersionTrack to listen the update of config, this pr also make the Debugger using the same way to change io limit.

What is the type of the changes?

  • New feature (a change which adds functionality)

How is the PR tested?

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No

Does this PR affect tidb-ansible?

No

NingLin-P added 5 commits Dec 27, 2019
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P

This comment has been minimized.

Copy link
Contributor Author

NingLin-P commented Dec 28, 2019

/run-all-tests

@overvenus overvenus requested a review from MyonKeminta Dec 30, 2019
Copy link
Contributor

overvenus left a comment

Rest LGTM

src/server/gc_worker.rs Outdated Show resolved Hide resolved
Signed-off-by: linning <linningde25@gmail.com>
@overvenus

This comment has been minimized.

Copy link
Contributor

overvenus commented Dec 31, 2019

LGTM, please resolve conflicts.

@NingLin-P

This comment has been minimized.

Copy link
Contributor Author

NingLin-P commented Dec 31, 2019

/run-unit-test

NingLin-P added 2 commits Jan 3, 2020
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P NingLin-P force-pushed the NingLin-P:dy-gc-worker-config branch from ff386ab to 8ccfa8b Jan 3, 2020
Copy link
Contributor

MyonKeminta left a comment

Rest LGTM

src/server/gc_worker.rs Outdated Show resolved Hide resolved
src/server/gc_worker.rs Outdated Show resolved Hide resolved
NingLin-P added 2 commits Jan 3, 2020
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P

This comment has been minimized.

Copy link
Contributor Author

NingLin-P commented Jan 3, 2020

/run-all-tests

@overvenus overvenus added this to the v4.0.0-beta milestone Jan 6, 2020
NingLin-P added 4 commits Jan 6, 2020
Signed-off-by: linning <linningde25@gmail.com>
…dy-gc-worker-config
Signed-off-by: linning <linningde25@gmail.com>
@NingLin-P

This comment has been minimized.

Copy link
Contributor Author

NingLin-P commented Jan 8, 2020

/run-unit-test

@NingLin-P

This comment has been minimized.

Copy link
Contributor Author

NingLin-P commented Jan 8, 2020

/run-unit-test

Copy link
Contributor

MyonKeminta left a comment

LGTM

@youjiali1995 youjiali1995 merged commit fc32fee into tikv:master Jan 8, 2020
3 checks passed
3 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.