Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb_query: fix get_valid_int_prefix in SELECT statement context #6425

Merged
merged 1 commit into from Jan 7, 2020

Conversation

@lonng
Copy link
Member

lonng commented Jan 7, 2020

Signed-off-by: Lonng heng@lonng.org

What have you changed?

Fix get_valid_int_prefix in SELECT statement context. The function get_valid_int_prefix has different behavior between SELECT and non-SELECT statement context.
See: https://github.com/pingcap/tidb/blob/d006443194ac535efcc312004fe0c8ace8d79e28/types/convert.go#L373

Don't assume reviewers understand the original issue.

What is the type of the changes?

  • Bugfix (a change which fixes an issue)

How is the PR tested?

  • Unit test
Signed-off-by: Lonng <heng@lonng.org>
@lonng lonng added the T: BugFix label Jan 7, 2020
@lonng

This comment has been minimized.

Copy link
Member Author

lonng commented Jan 7, 2020

/run-all-tests

@lonng lonng merged commit 19a3f62 into tikv:master Jan 7, 2020
6 checks passed
6 checks passed
DCO All commits are signed off!
Details
idc-jenkins-ci-tikv/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-copr-test Jenkins job succeeded.
Details
idc-jenkins-ci-tikv/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
@lonng lonng deleted the lonng:fix-get-valid-int-prefix branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.