[3.1] Update rust-toolchain to 2019-12-20, and cherry-pick #6374 - #6462
Merged
Conversation
kennytm
added
type/cherry-pick
kennytm
force-pushed
the
cherry-pick-6374-to-3.1
branch
3 times, most recently
from
January 10, 2020 18:48
4fb9f36 to
33fbf1f
Compare
…iminate the extra copies to memory when backing up a file (tikv#6374) Signed-off-by: kennytm <kennytm@gmail.com>
- remove stabilized features - unlikely() is now safe - uninitialized() is deprecated (the simple replacement here is equally unsafe though) Signed-off-by: kennytm <kennytm@gmail.com>
kennytm
force-pushed
the
cherry-pick-6374-to-3.1
branch
from
January 10, 2020 18:54
33fbf1f to
819f2b3
Compare
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
PTAL @overvenus @5kbpers |
kennytm
added
status/LGT2
Contributor
Author
|
PTAL @AndreMouche |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What have you changed?
async-speed-limitwhich relies onfutures-io, which cannot be compiled using the oldnightly-2019-06-14toolchain. Therefore, the Rust version is updated to be the same as current master.lazy_staticis updated to 1.4unlikelyis now safe, so remove the redundantunsafe {}block aroundunlikelycallsPlease explain in detail what the changes are in this PR and why they are needed:
Don't assume reviewers understand the original issue.
What is the type of the changes?
How is the PR tested?
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Does this PR affect
tidb-ansible?No
Refer to a related PR or issue link (optional)
#6374.
Benchmark result if necessary (optional)
Any examples? (optional)