coprocessor: migrate password function from TiDB #7777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psinghal20
force-pushed
the
migrate-password
branch
from
98e3365
to
9838b0e
Compare
Signed-off-by: psinghal20 <psinghal20@gmail.com>
Signed-off-by: psinghal20 <psinghal20@gmail.com>
|
LGTM |
TennyZhuang
approved these changes
May 12, 2020
|
@Fullstop000 PTAL |
Fullstop000
reviewed
May 12, 2020
| let op = Expression::build(&mut ctx, op).unwrap(); | ||
| let got = op.eval(&mut ctx, &[]).unwrap(); | ||
| let exp = Datum::Bytes(exp_str.as_bytes().to_vec()); | ||
| assert_eq!(got, exp, "password('{:?}')", input_str); |
There was a problem hiding this comment.
It could be better to add testing for empty input and the warning I think :)
There was a problem hiding this comment.
@Fullstop000 I have added a Null case test, similar to the above tests. PTAL.
Signed-off-by: psinghal20 <psinghal20@gmail.com>
|
@sre-bot /approve |
|
/merge |
|
/approve |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: psinghal20 psinghal20@gmail.com
What problem does this PR solve?
Issue Number: closes #6776
Problem Summary:
What is changed and how it works?
Migrates the scalar function password from TiDB.
I am not sure of the correct way to report deprecation warning, let me know if any changes are required. @andylokandy PTAL
Check List
Tests