-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copr: Implement ChunkedVecEnum #8948
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
|
Unittests will come in following commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
components/tidb_query_datatype/src/codec/data_type/chunked_vec_enum.rs
Outdated
Show resolved
Hide resolved
components/tidb_query_datatype/src/codec/data_type/chunked_vec_enum.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
| fn test_basics() { | ||
| let mut x = setup(); | ||
| x.push(None); | ||
| x.push(Some(Enum::new(x.data.clone(), 2))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding support for directly pushing usize values to ChunkedEnumVec, so as to reduce overhead. We may work on this later.
|
|
||
| // FIXME: we need a set_data here, but for now, we set directly | ||
| let mut buf = BufferVec::new(); | ||
| buf.push("我好强啊"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@Xuanwo merge failed. |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/merge |
|
@Xuanwo Oops! auto merge is restricted to Committers of the SIG.You are not a committer or co-leader or leader. |
|
/merge |
|
/merge |
1 similar comment
|
/merge |
|
/run-all-tests |
|
@Xuanwo merge failed. |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
@Xuanwo merge failed. |
|
/merge |
|
/run-all-tests |
|
@Xuanwo merge failed. |
CI failed due to this panic. Will fixed by #8971. |
|
#8971 has been merged, let's rock! |
|
/merge |
|
/run-all-tests |
|
@Xuanwo merge failed. |
|
/run-all-tests |
|
/run-all-tests |
|
I wonder why I tried to add |
This module is not used by any code in TiKV, so we may add it later. cc @Xuanwo would you please include this module together with ChunkedVecSet in #8988 ? |
|
OK, I will give it a try. |
What problem does this PR solve?
Implement ChunkedVecEnum
Check List
Tests