copr: Implement ChunkedVecSet

[Xuanwo]

What problem does this PR solve?

Implement ChunkedVecSet

Check List

Tests

• Unit test

[Xuanwo]

ChunkedVecSet's implementation looks nearly the same with ChunkedVecEnum, can we share them in some way?

[Xuanwo]

/run-all-tests

[skyzh]

Rest LGTM

[Xuanwo]

[2020-11-09T05:36:36.834Z]    --> components/tidb_query_datatype/src/codec/data_type/chunked_vec_enum.rs:119:10

[2020-11-09T05:36:36.834Z]     |

[2020-11-09T05:36:36.834Z] 119 | impl<'a> ChunkRef<'a, EnumRef<'a>> for &'a ChunkedVecEnum {

[2020-11-09T05:36:36.834Z]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `EvaluableRef<'a>` is not implemented for `EnumRef<'a>`

[2020-11-09T05:36:36.834Z]     | 

[2020-11-09T05:36:36.834Z]    ::: components/tidb_query_datatype/src/codec/data_type/mod.rs:126:27

[2020-11-09T05:36:36.834Z]     |

[2020-11-09T05:36:36.834Z] 126 | pub trait ChunkRef<'a, T: EvaluableRef<'a>>: Copy + Clone + std::fmt::Debug + Send + Sync {

[2020-11-09T05:36:36.834Z]     |                           ---------------- required by this bound in `data_type::ChunkRef`

[2020-11-09T05:36:36.834Z] 

[2020-11-09T05:36:36.834Z] error[E0277]: the trait bound `SetRef<'a>: EvaluableRef<'a>` is not satisfied

[2020-11-09T05:36:36.834Z]    --> components/tidb_query_datatype/src/codec/data_type/chunked_vec_set.rs:115:10

[2020-11-09T05:36:36.834Z]     |

[2020-11-09T05:36:36.834Z] 115 | impl<'a> ChunkRef<'a, SetRef<'a>> for &'a ChunkedVecSet {

[2020-11-09T05:36:36.834Z]     |          ^^^^^^^^^^^^^^^^^^^^^^^^ the trait `EvaluableRef<'a>` is not implemented for `SetRef<'a>`

[2020-11-09T05:36:36.834Z]     | 

[2020-11-09T05:36:36.835Z]    ::: components/tidb_query_datatype/src/codec/data_type/mod.rs:126:27

[2020-11-09T05:36:36.835Z]     |

[2020-11-09T05:36:36.835Z] 126 | pub trait ChunkRef<'a, T: EvaluableRef<'a>>: Copy + Clone + std::fmt::Debug + Send + Sync {

[2020-11-09T05:36:36.835Z]     |                           ---------------- required by this bound in `data_type::ChunkRef`

It looks like we need to implement all the traits before we export them, so I planed to export them in later PRs (after we implement them all)

@skyzh @zhongzc any ideas?

[zhongzc]

I am not sure. I prefer to merge runnable / testable codes into master. Is it too hard to achieve?

[skyzh]

I think implement EvaluableRef with panic! is okay. They won't be called until you add them to VectorValue.

[Xuanwo]

My plan is to add set in this PR and add them to VectorValue/ScalarValue enum in another PR with all required traits implemented, except the real enum/set data loading (maybe with panic!, as tidb doesn't have enum/set push down, so these code will be be called. )

Is this plan OK?

[skyzh]

My plan is to add set in this PR and add them to VectorValue/ScalarValue enum in another PR with all required traits implemented, except the real enum/set data loading (maybe with panic!, as tidb doesn't have enum/set push down, so these code will be be called. )

Is this plan OK?

Sounds good to me. So I think in this PR, the two modules ChunkedEnumVec and ChunkedSetVec could be introduced without importing. And we could assemble them together with next PR.

[skyzh]

By the way, I think it takes little effort to implement EvaluableRef and ChunkRef with panic, and we could unit-test ChunkedVecs now. But if you intend to implement them later, I think it's okay.

[Xuanwo]

All code has been implemented locally, just splitted into different PRs, I prefer split EvaluableRef related works into another PR so I don't need pick which file part to commit. And this will completely disappear when the next PR (maybe today) is presented and we will be able to execute the full tests.

[skyzh]

All code has been implemented locally, just splitted into different PRs, I prefer split EvaluableRef related works into another PR so I don't need pick which file part to commit. And this will completely disappear when the next PR (maybe today) is presented and we will be able to execute the full tests.

Alright!

[zhongzc]

tikv/components/tidb_query_datatype/src/codec/mysql/set.rs

Line 42 in 50aa79a

if self.value & (1 << idx) == 0 {

+ if !self.is_set(idx) { 

[zhongzc]

/cc @iosmanthus

[andylokandy]

I don't think it's appropriate to merge a PR that doesn't compile. PR should be considered as a minimum compliable unit.

[Xuanwo]

OK, I will export mod in this PR to make sure all code compliable.

[Xuanwo]

/run-all-tests

[Xuanwo]

PTAL @zhongzc

[zhongzc]

Filename can be more unified, codec/mysql/enums.rs -> codec/mysql/enum.rs.

BTW, can you add copyright info for the newly added files?

[skyzh]

Filename can be more unified, codec/mysql/enums.rs -> codec/mysql/enum.rs.

BTW, can you add copyright info for the newly added files?

If doing so, importing this module mod enum will include a keyword in Rust.

[Xuanwo]

enum cloud not be used as a mod, statement mod enum can't be compiled.

[zhongzc]

If doing so, importing this module mod enum will include a keyword in Rust.

interesting..

[zhongzc]

LGTM

[skyzh]

/merge

[ti-srebot]

/run-all-tests

[ti-srebot]

@Xuanwo merge failed.

[ti-srebot]

/run-all-tests

[ti-srebot]

@Xuanwo merge failed.

[zhongzc]

/merge

[ti-srebot]

/run-all-tests