copr: Add enum/set support for codegen

[Xuanwo]

Signed-off-by: Xuanwo github@xuanwo.io

What problem does this PR solve?

Add enum support in codegen, after this PR merged, we can implement copr functions like:

#[rpn_fn]
fn cast_set_as_int(val: SetRef) -> Result<Option<Int>> {
    Ok(Some(val.value() as i64))
}

Check List

Tests

• Unit test
• Integration test

[Xuanwo]

Let's merge this PR into previous one #9106

[Xuanwo]

PTAL @skyzh @zhongzc @andylokandy

[skyzh]

LGTM. What about merging logic of xxxRef? (e.g. pack them into an enum), so as to reduce duplicated code?

[Xuanwo]

What about merging logic of xxxRef? (e.g. pack them into an enum), so as to reduce duplicated code?

Worth a try, maybe we can implement it in another PR.

[Xuanwo]

ping @skyzh to take a look

[skyzh]

Great!

[Xuanwo]

ping @andylokandy , PTAL

[andylokandy]

Generally LGTM, please add a test for the macro expansion result, 'cause i think it can help new comer figure out what exactly the macro does.

[Xuanwo]

Maybe I can add a macro expansion test for rpn_fn in another PR? (I think this test must be very verbose).

[andylokandy]

However, I think the tests are tightly related to the pr itself unlike additional improvement.

[Xuanwo]

OK, I will add a test here.

[andylokandy]

If an ident in a big token tree goes wrong, it'll be hard to locate. I suggest renaming to token_tree_equal, to return the bool (sorry for the last comment) and assert it in the test.

[Xuanwo]

If an ident in a big token tree goes wrong, it'll be hard to locate. I suggest renaming to token_tree_equal, to return the bool (sorry for the last comment) and assert it in the test.

I will look into this to find a solution for macro debuging.

[Xuanwo]

Debug message looks like following:

expect: TokenStream [
    Ident {
        sym: row_index,
    },
    Punct {
        char: ',',
        spacing: Alone,
    },
    Ident {
        sym: vaxl,
    },
], actual: TokenStream [
    Ident {
        sym: row_index,
    },
    Punct {
        char: ',',
        spacing: Alone,
    },
    Ident {
        sym: val,
    },
]
thread 'rpn_function::tests_normal::test_enum_fn_generate_real_fn_trait_impl' panicked at 'expect: TokenStream [
    Ident {
        sym: row_index,
    },
    Punct {
        char: ',',
        spacing: Alone,
    },
    Ident {
        sym: vaxl,
    },
], actual: TokenStream [
    Ident {
        sym: row_index,
    },
    Punct {
        char: ',',
        spacing: Alone,
    },
    Ident {
        sym: val,
    },
]', components/tidb_query_codegen/src/rpn_function.rs:1747:9

Maybe this is enough? I found it's hard to get the token's location via public APIs.

[andylokandy]

LGTM, well done.

[andylokandy]

/merge

[ti-srebot]

/run-all-tests

[ti-srebot]

@Xuanwo merge failed.

[ti-srebot]

/run-all-tests

[ti-srebot]

@Xuanwo merge failed.

[andylokandy]

/merge

[ti-srebot]

/run-all-tests