Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: Add ENUM support for aggr MAX #9146

Merged
merged 5 commits into from
Dec 3, 2020
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 30, 2020

Signed-off-by: Xuanwo github@xuanwo.io

What problem does this PR solve?

Add ENUM support for aggr MAX

What is changed and how it works?

  • Implement a new aggr for ENUM: AggFnExtremumForEnum

Check List

Tests

  • Unit test
  • Integration test

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2020
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 1, 2020

cc @andylokandy , can you take a look on this PR?

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 3, 2020

@zhongzc PTAL

Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Contributor

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 3, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 3, 2020
@zhongzc
Copy link
Contributor

zhongzc commented Dec 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 3, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit f06dc0d into tikv:master Dec 3, 2020
@Xuanwo Xuanwo deleted the copr-aggr-mum branch December 3, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants