Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: Implement ENUM support for aggr SUM #9148

Merged
merged 4 commits into from
Dec 1, 2020

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 30, 2020

Signed-off-by: Xuanwo github@xuanwo.io

What problem does this PR solve?

Implement ENUM support for aggr SUM

What is changed and how it works?

  • Implement a new aggr for ENUM: AggrFnSumForEnum

Check List

Tests

  • Unit test
  • Integration test

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 30, 2020

ping @skyzh @andylokandy PTAL

Signed-off-by: Xuanwo <github@xuanwo.io>
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2020
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 1, 2020

ping @skyzh, please take this PR a look

Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 1, 2020
@skyzh skyzh added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 9b8785a into tikv:master Dec 1, 2020
@Xuanwo Xuanwo deleted the copr-aggr-sum branch December 1, 2020 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants