Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copr: Implement ENUM/SET support for aggr AVG #9186

Merged
merged 3 commits into from
Dec 4, 2020
Merged

copr: Implement ENUM/SET support for aggr AVG #9186

merged 3 commits into from
Dec 4, 2020

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 4, 2020

What problem does this PR solve?

Implement ENUM/SET support for aggr AVG

Should be merged after #9184

Check List

Tests

  • Unit test
  • Integration test

@Xuanwo
copr: Implement ENUM/SET support for aggr AVG
9b639c9 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as ready for review December 4, 2020 09:17
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 4, 2020

PTAL @skyzh @andylokandy @zhongzc

@Xuanwo Xuanwo mentioned this pull request Dec 4, 2020
Closed
13 tasks
@Xuanwo
Let clippy happy
aa62b65 
Signed-off-by: Xuanwo <github@xuanwo.io>
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 4, 2020
@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 4, 2020
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 4, 2020

ping @skyzh , Let's merge!

@skyzh skyzh added the status/can-merge Indicates a PR has been approved by a committer. label Dec 4, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 3bae18b into tikv:master Dec 4, 2020
@Xuanwo Xuanwo deleted the copr-avg branch December 4, 2020 17:28
@skyzh skyzh mentioned this pull request Dec 9, 2020
Merged
Little-Wallace added a commit to Little-Wallace/tikv that referenced this pull request Dec 10, 2020
@Little-Wallace
Squashed commit of the following:
51e0da4 
commit cea0f29
Author: Connor <zbk602423539@gmail.com>
Date:   Thu Dec 10 06:37:22 2020 +0800

    tikv_util: Extract collections from tikv_util to avoid circular dependencies (tikv#9206)

    Signed-off-by: Connor <zbk602423539@gmail.com>

commit 1df1cad
Author: Xuanwo <github@xuanwo.io>
Date:   Wed Dec 9 21:25:52 2020 +0800

    copr: Add enum/set support for codegen (tikv#9133)

    Signed-off-by: Xuanwo <github@xuanwo.io>

commit e402023
Author: wangggong <793160615@qq.com>
Date:   Wed Dec 9 14:55:48 2020 +0800

    copr: (non-)vectorized compress & uncompress (tikv#9141)

    Signed-off-by: wangggong <793160615@qq.com>

commit b8fca7c
Author: Yilin Chen <sticnarf@gmail.com>
Date:   Tue Dec 8 16:06:17 2020 +0800

    txn: support fallback from async commit (take 2) (tikv#9196)

    Signed-off-by: Yilin Chen <sticnarf@gmail.com>

commit d7b47fa
Author: Jay <BusyJay@users.noreply.github.com>
Date:   Tue Dec 8 15:37:47 2020 +0800

    *: update dep (tikv#9201)

    Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

commit 5777bb6
Author: Nick Cameron <nrc@ncameron.org>
Date:   Tue Dec 8 15:39:18 2020 +1300

    txn: some async commit unit tests (tikv#9183)

    Signed-off-by: Nick Cameron <nrc@ncameron.org>

commit 0f135cb
Author: Liqi Geng <gengliqiii@gmail.com>
Date:   Mon Dec 7 09:33:49 2020 -0600

    raftstore: use async ready raft (tikv#9177)

    Signed-off-by: gengliqi <gengliqiii@gmail.com>

commit 0632bd2
Author: 5kbpers <tangminghua@pingcap.com>
Date:   Mon Dec 7 18:03:18 2020 +0800

    cdc: compatible with hibernate region (tikv#8907)

    Signed-off-by: 5kbpers <tangminghua@pingcap.com>

commit 623559a
Author: Long Deng <37360259+ldeng-ustc@users.noreply.github.com>
Date:   Mon Dec 7 17:07:18 2020 +0800

    copr: index scan return extra partiton id column when reading global index (tikv#8603)

    Signed-off-by: ldeng <ldeng@mail.ustc.edu.cn>

commit e146fae
Author: yiwu-arbug <yiwu@pingcap.com>
Date:   Sun Dec 6 21:36:18 2020 -0800

    encryption: Add config to gate the log style file dictionary optimization (tikv#9191)

    Signed-off-by: Yi Wu <yiwu@pingcap.com>

commit 4a41744
Author: Pramod Biligiri <pramodbiligiri@gmail.com>
Date:   Mon Dec 7 09:38:48 2020 +0530

    txn: code level docs for prewrite.rs (tikv#9189)

    Signed-off-by: Pramod Biligiri <pramodbiligiri@gmail.com>

commit 3bae18b
Author: Xuanwo <github@xuanwo.io>
Date:   Sat Dec 5 00:21:49 2020 +0800

    copr: Implement ENUM/SET support for aggr AVG  (tikv#9186)

    Signed-off-by: Xuanwo <github@xuanwo.io>

commit 21df48d
Author: Xinye Tao <xy.tao@outlook.com>
Date:   Fri Dec 4 17:34:46 2020 +0800

    tests: stabilize lease related tests (tikv#8955)

    Signed-off-by: tabokie <xy.tao@outlook.com>

commit 3326368
Author: Xuanwo <github@xuanwo.io>
Date:   Fri Dec 4 17:13:48 2020 +0800

    copr: Implement SET support for MAX/MIN/SUM (tikv#9184)

    Signed-off-by: Xuanwo <github@xuanwo.io>

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

@andylokandy andylokandy andylokandy approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xuanwo @ti-srebot @skyzh @andylokandy