This repository has been archived by the owner on Nov 19, 2023. It is now read-only.
Fix an issue where message text occasionally becomes unselectable. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… become unselectable. Occasionally, message TextViews would, despite being marked selectable in the view XML, fail to allow selection (a warning gets printed to logcat when this occurs). The root cause of this issue seems the RecyclerView ViewHolder lifecycle, a part of which involves updating the text displayed in the message TextView before the view is attached to a window. This causes the TextView to internally cache the fact that its view hierarchy does not support selection handles, and therefore disallow selection. The fix is to call setText to "update" the text after the TextView has been reattached to a window. This forces a call to android.widget.Editor#prepareCursorControllers, and re-allows selection. The timestamp TextView is not affected due to an implementation detail in how the layout of the RecyclerView items are computed; since the message is marked as being to the right of the timestamp, the code path to calculate the width of the timestamp TextView calls prepareCursorControllers for us.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a full write-up in the commit message. This bug was a pain to track down.
(This is probably the only occasion when the excessive amount of logcat messages from the Android system libraries actually came in handy!)