New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More id dropping at low zooms (roads) #1002

Open
nvkelso opened this Issue Aug 29, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@nvkelso
Member

nvkelso commented Aug 29, 2016

In completing #952, we have mostly removed id properties on merged features (where the id wasn't deterministic.

But zoom 14 is a little interesting, though, as some minor roads are still getting IDs?

type: "MultiLineString",
properties: {
sort_key: 358,
landuse_kind: "retail",
kind: "minor_road",
source: "openstreetmap.org",
kind_detail: "service"
},
arcs: [
[
3870
],
[
3871
]
]
},
{
type: "LineString",
properties: {
source: "openstreetmap.org",
kind: "minor_road",
name: "Gardener Rd.",
kind_detail: "residential",
sort_key: 360,
landuse_kind: "parking",
id: 8915543

@nvkelso nvkelso added this to the v1.1.0 milestone Aug 29, 2016

@zerebubuth

This comment has been minimized.

Show comment
Hide comment
@zerebubuth

zerebubuth Aug 30, 2016

Member

We don't drop the id when the feature was unique and there were no merge candidates. Because the feature is unique, the ID is still meaningful. In this case, we don't drop name on minor_road until z13 and the combination of name and landuse_kind probably makes it unique.

Member

zerebubuth commented Aug 30, 2016

We don't drop the id when the feature was unique and there were no merge candidates. Because the feature is unique, the ID is still meaningful. In this case, we don't drop name on minor_road until z13 and the combination of name and landuse_kind probably makes it unique.

@nvkelso nvkelso changed the title from More id dropping on merged features to More id dropping on merged road features Oct 5, 2016

@nvkelso nvkelso modified the milestones: v1.1.0, v1.2.0 Apr 4, 2017

@nvkelso nvkelso changed the title from More id dropping on merged road features to More id dropping at low zooms (roads) May 4, 2017

@nvkelso nvkelso modified the milestones: v1.6.0, v1.5.0 Jun 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment