New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed and historic buildings should indicate that in kind_detail #1026

Open
nvkelso opened this Issue Sep 8, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@nvkelso
Member

nvkelso commented Sep 8, 2016

We moved the old v0.10 kind values into kind_detail in v1, but we have a post-processing step that evaluates feature names and resets the kind to closed or historical. For the pois layer that's fine, but for the buildings layer the output needs to go into kind_detail.

Needs updates to indicate which property is being evaluated (kind versus kind_detail):

Related test is only looking at POIs, so we'll need to modify that or add new test that just looks at buildings:

@nvkelso nvkelso added the bug label Sep 8, 2016

@nvkelso nvkelso added this to the v1.0.0 milestone Sep 8, 2016

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Sep 8, 2016

Member

Related issue: #842.

Member

nvkelso commented Sep 8, 2016

Related issue: #842.

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Sep 8, 2016

Member

This is an edge case, and can probably be addressed in v1.1 as a bug fix.

Member

nvkelso commented Sep 8, 2016

This is an edge case, and can probably be addressed in v1.1 as a bug fix.

@nvkelso nvkelso modified the milestones: v1.1.0, v1.0.0 Sep 9, 2016

@nvkelso nvkelso modified the milestones: v1.2.0, v1.1.0 Dec 28, 2016

@nvkelso nvkelso modified the milestones: v1.6.0, v1.7.0 Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment