New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-road and A-road shield_text cleanup #1062

Closed
nvkelso opened this Issue Sep 21, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@nvkelso
Member

nvkelso commented Sep 21, 2016

This is followup refinement for work originally performed in #192.

For E-roads, A-roads, and probably others, the leading character should – it's the 2nd space character that should be dropped.

Here are those examples again as OSM ways & relations:

  • shield_text of A151 from ref of A 151 with way and relation
  • shield_text of E402 from ref of E 402 with way and relation

Looking at TagInfo these aren't commonly tag'd in Europe so this is a v1.1 cleanup task.

@nvkelso nvkelso added this to the v1.1.0 milestone Sep 21, 2016

@nvkelso nvkelso modified the milestones: v1.1.0, v1.2.0 Apr 4, 2017

@nvkelso nvkelso modified the milestones: v1.5.0, v1.4.0 May 4, 2017

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Oct 24, 2017

Member

Another example from user report:

Some labels for A roads in UK Derbyshire area are mislabelled

  • An example is the A52 Stoke on Trent to Derby City. Its labelled just 52 without the A.
    • @nvkelso comment: This is an example of the focus of this issue, that the A should be retained by the space dropped.
  • M1 is labelled - 13
    • @nvkelso comment: This is a data problem in that the E-Road network is present but M1 is only on the road segment attributes and not in a network relation. Once it's in a network relation (and I proposed adding it just for that one road in OSM for testing purposes) then the M1 should sort before the E13 in the shield and network lists.
Member

nvkelso commented Oct 24, 2017

Another example from user report:

Some labels for A roads in UK Derbyshire area are mislabelled

  • An example is the A52 Stoke on Trent to Derby City. Its labelled just 52 without the A.
    • @nvkelso comment: This is an example of the focus of this issue, that the A should be retained by the space dropped.
  • M1 is labelled - 13
    • @nvkelso comment: This is a data problem in that the E-Road network is present but M1 is only on the road segment attributes and not in a network relation. Once it's in a network relation (and I proposed adding it just for that one road in OSM for testing purposes) then the M1 should sort before the E13 in the shield and network lists.
@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Apr 4, 2018

Member

Here's an A-road that's loosing it's number in the shield_text conversion in Rome, /cc @sensescape.

http://localhost:8000/#11/41.8293/372.6037

image 1
image

Member

nvkelso commented Apr 4, 2018

Here's an A-road that's loosing it's number in the shield_text conversion in Rome, /cc @sensescape.

http://localhost:8000/#11/41.8293/372.6037

image 1
image

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Apr 4, 2018

Member

Related: #1483

Member

nvkelso commented Apr 4, 2018

Related: #1483

@sensescape sensescape referenced this issue Apr 20, 2018

Closed

Additional shield_text cleanup #1491

21 of 57 tasks complete
@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Apr 30, 2018

Member

This is working in "prod" Nextzen endpoint, closing.

Member

nvkelso commented Apr 30, 2018

This is working in "prod" Nextzen endpoint, closing.

@nvkelso nvkelso closed this Apr 30, 2018

@wafflebot wafflebot bot removed the in review label Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment