New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine poi min_zoom for place_of_worship and other features #1085

Open
nvkelso opened this Issue Sep 23, 2016 · 8 comments

Comments

Projects
None yet
1 participant
@nvkelso
Member

nvkelso commented Sep 23, 2016

Following up from #1084 which noted a funky min_zoom for Grace Cathedral in SF...

I suspect:

  • significant place_of_worship features don't always show up early enough, like Grace Cathedral in SF. I suspect we need to measure areas from landuse polygons differently than areas from buildings to get it more back to the earlier behavior. The current zooms feel good for landuse based areas (cap at zoom 12), but the buildings probably need to reset to be closer to the earlier v0.10 behavior, but with a cap at zoom 14.

screen shot 2016-09-22 at 23 00 12

screen shot 2016-09-22 at 22 59 49

screen shot 2016-09-22 at 22 59 38

screen shot 2016-09-22 at 22 58 34

- `garden` zooms just seem way off with far too many at mid-zooms, I suspect because of the 12 in the filter:

min_zoom: { min: [ 12, { max: [ { lit: zoom }, { lit: *tier6_min_zoom } ] }, 16 ] }

versus something in the more dominant pattern:

min_zoom: { min: [ { max: [ 12, { lit: zoom }, { lit: *tier6_min_zoom } ] }, 16 ] }

In the Bubble Wrap stylesheet I'm using this to throttle garden features back:

garden-area-early:
                 filter:
                     all:
                         - kind: [garden, allotments]
                     any:
                         # limit show smaller landuse areas to higher zooms
                         - { $zoom: [12], area: { max: 500000 } }
                         - { $zoom: [13], area: { max: 100000 } }
                         - { $zoom: [14], area: { max: 10000 } }
                         - { $zoom: [15], area: { max: 5000 } }
                 draw:
                     icons:
                         visible: false

screen shot 2016-09-22 at 22 49 53

screen shot 2016-09-22 at 22 49 21

screen shot 2016-09-22 at 22 48 58

screen shot 2016-09-22 at 22 48 47

@nvkelso nvkelso added this to the v1.1.0 milestone Sep 23, 2016

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Sep 23, 2016

Member

Gardens without an area should only be min_zoom 16.

Member

nvkelso commented Sep 23, 2016

Gardens without an area should only be min_zoom 16.

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Sep 23, 2016

Member

nursing_home shouldn't show up before zoom 15.

screen shot 2016-09-22 at 23 20 30

Member

nvkelso commented Sep 23, 2016

nursing_home shouldn't show up before zoom 15.

screen shot 2016-09-22 at 23 20 30

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Sep 23, 2016

Member

cafe and restaurant should also not be shown earlier than zoom 15.

Member

nvkelso commented Sep 23, 2016

cafe and restaurant should also not be shown earlier than zoom 15.

@nvkelso nvkelso changed the title from Refine tier 6 poi min_zoom for place_of_worship and garden features to Refine poi min_zoom for place_of_worship, garden, and other features Sep 23, 2016

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Oct 5, 2016

Member

This is a more complete list:

  • kind: [garden, allotments]
  • kind: [police, fire_station, substation, plant, wastewater_plant, water_works]
  • kind: [cafe, restaurant, nursing_home]
  • kind: [parking, pedestrian, common, pitch, place_of_worship, playground, school, nursing_home]
Member

nvkelso commented Oct 5, 2016

This is a more complete list:

  • kind: [garden, allotments]
  • kind: [police, fire_station, substation, plant, wastewater_plant, water_works]
  • kind: [cafe, restaurant, nursing_home]
  • kind: [parking, pedestrian, common, pitch, place_of_worship, playground, school, nursing_home]

@nvkelso nvkelso added the bug label Oct 5, 2016

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Oct 5, 2016

Member

Crazy early police station at 11/52.5214/13.4232 in Berlin:

screen shot 2016-10-04 at 22 31 08

Member

nvkelso commented Oct 5, 2016

Crazy early police station at 11/52.5214/13.4232 in Berlin:

screen shot 2016-10-04 at 22 31 08

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Apr 4, 2017

Member

Note garden fix is in #1188.

Member

nvkelso commented Apr 4, 2017

Note garden fix is in #1188.

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Apr 20, 2017

Member

Removing garden from title as we fixed that in #1188.

Member

nvkelso commented Apr 20, 2017

Removing garden from title as we fixed that in #1188.

@nvkelso nvkelso changed the title from Refine poi min_zoom for place_of_worship, garden, and other features to Refine poi min_zoom for place_of_worship and other features Apr 20, 2017

@nvkelso nvkelso modified the milestones: v1.1.0, v1.2.0 Apr 25, 2017

@nvkelso nvkelso added the loe medium label Jul 27, 2017

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Jul 27, 2017

Member

Subtask of #1351.

Member

nvkelso commented Jul 27, 2017

Subtask of #1351.

@nvkelso nvkelso modified the milestones: v1.5.0, v1.6.0 Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment