New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate area/volume properties on merged buildings #1095

Open
rmarianski opened this Issue Oct 3, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@rmarianski
Member

rmarianski commented Oct 3, 2016

  • What did you see?

On merged buildings, the area/volume is calculated from all features that got merged together. Although we assign a scale_rank, it can be surprising when trying to use it for area/volume filtering in tangram styles.

  • What did you expect to see?

Perhaps we should consider dropping the area/volume properties on merged features? We should also consider if we want to do this everywhere we merge, like for the landuse layer.
The original motivation was to cut down on tile sizes by returning fewer features back. We could also try merging features that actually intersect somewhere, but this would probably complicate processing as well as result in larger tile sizes.

  • What map location are you having problems with? City and country are helpful, as well as tile coordinates or latitude / longitude.

For example:

/buildings/14/4827/6157.json
OSM id 281343104 gets merged in.

@rmarianski rmarianski added this to the v1.1.0 milestone Oct 3, 2016

@nvkelso nvkelso modified the milestones: v1.2.0, v1.1.0 Dec 28, 2016

@nvkelso nvkelso modified the milestones: v1.6.0, v1.7.0 Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment