New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name:short > name_short #1102

Open
nvkelso opened this Issue Oct 5, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@nvkelso
Member

nvkelso commented Oct 5, 2016

Generally our convention has been to convert : to _ in property names, reserving : for localized name variants.

But name:short didn't receive this treatment in the v1.0 milestone.

@nvkelso nvkelso added this to the v1.1.0 milestone Oct 5, 2016

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Oct 5, 2016

Member

(It's also confusing between short_name and name:short – are these really different?)

Member

nvkelso commented Oct 5, 2016

(It's also confusing between short_name and name:short – are these really different?)

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Oct 5, 2016

Member

We support all these names, are they really necessary?

  • alt_name
  • int_name
  • loc_name
  • name:short - For example: CA for California.
  • name_left
  • name_right
  • nat_name
  • official_name
  • old_name
  • reg_name
  • short_name

Name localization

Localized name properties (common-optional):

  • name:*
  • alt_name:*
  • old_name:*
  • name:left:*
  • name:right:*
Member

nvkelso commented Oct 5, 2016

We support all these names, are they really necessary?

  • alt_name
  • int_name
  • loc_name
  • name:short - For example: CA for California.
  • name_left
  • name_right
  • nat_name
  • official_name
  • old_name
  • reg_name
  • short_name

Name localization

Localized name properties (common-optional):

  • name:*
  • alt_name:*
  • old_name:*
  • name:left:*
  • name:right:*
@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Oct 5, 2016

Member

Should name:left and name:right be renamed name_left and name_right?

Member

nvkelso commented Oct 5, 2016

Should name:left and name:right be renamed name_left and name_right?

@zerebubuth

This comment has been minimized.

Show comment
Hide comment
@zerebubuth

zerebubuth Oct 5, 2016

Member

For consistency, might it be better to make them left_name and right_name, and back-fill missing short_name values with name:short where that's present? We should look into if there are any elements with both short_name and name:short, as it seems likely to me that they're alternative names for the same thing - in which case I'd expect there to be either no elements with that, or elements with both having the same value. From taginfo: 527 uses of name:short and 71,597 uses of short_name.

Member

zerebubuth commented Oct 5, 2016

For consistency, might it be better to make them left_name and right_name, and back-fill missing short_name values with name:short where that's present? We should look into if there are any elements with both short_name and name:short, as it seems likely to me that they're alternative names for the same thing - in which case I'd expect there to be either no elements with that, or elements with both having the same value. From taginfo: 527 uses of name:short and 71,597 uses of short_name.

@nvkelso nvkelso added the ready label Oct 14, 2016

@nvkelso nvkelso removed the ready label Oct 31, 2016

@nvkelso nvkelso modified the milestones: v1.1.0, v1.2.0 Apr 4, 2017

@nvkelso nvkelso modified the milestones: v1.6.0, v1.5.0 Jun 27, 2017

@nvkelso nvkelso modified the milestones: v1.6.0, v2.0.0 Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment