New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this lake loses `kind: lake` tag > z9 #984

Open
meetar opened this Issue Aug 23, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@meetar
Contributor

meetar commented Aug 23, 2016

  • What did you see?

Past zoom 9, this feature of kind: lake loses that tag.

  • What did you expect to see?

Tag would remain.

  • What map location are you having problems with? City and country are helpful, as well as tile coordinates or latitude / longitude.

http://tangrams.github.io/explorer/#9.0/35.2348/136.0881/kind/lake

  • Screenshot? Props for animated gifs.

biwako

@zerebubuth

This comment has been minimized.

Show comment
Hide comment
@zerebubuth

zerebubuth Aug 23, 2016

Member

Looks like we're not picking up this lake from OSM, so it drops out when we transition from NE. The relation multi-polygon looks like it should come through as a lake (it's tagged natural=water), so further investigation is required.

Member

zerebubuth commented Aug 23, 2016

Looks like we're not picking up this lake from OSM, so it drops out when we transition from NE. The relation multi-polygon looks like it should come through as a lake (it's tagged natural=water), so further investigation is required.

@meetar meetar changed the title from lakes lose `kind: lake` tag > z9 to this lake loses `kind: lake` tag > z9 Aug 23, 2016

@zerebubuth zerebubuth self-assigned this Aug 23, 2016

@zerebubuth

This comment has been minimized.

Show comment
Hide comment
@zerebubuth

zerebubuth Aug 23, 2016

Member

Oh, wait... I see what's happening here. The lake is tagged natural=water, water=lake, and we don't have a special case for that, we're just assigning kind: water. There are probably many features out there which NE considers lakes but which are only tagged as more general "water" in OSM.

@nvkelso given that there's a water=lake additional tag on this particular natural=water, should we use that to "upgrade" it to a kind: lake?

Member

zerebubuth commented Aug 23, 2016

Oh, wait... I see what's happening here. The lake is tagged natural=water, water=lake, and we don't have a special case for that, we're just assigning kind: water. There are probably many features out there which NE considers lakes but which are only tagged as more general "water" in OSM.

@nvkelso given that there's a water=lake additional tag on this particular natural=water, should we use that to "upgrade" it to a kind: lake?

@zerebubuth zerebubuth assigned nvkelso and unassigned zerebubuth Aug 25, 2016

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Aug 25, 2016

Member

Yeah, I think so. Tagging for v1.1.

Member

nvkelso commented Aug 25, 2016

Yeah, I think so. Tagging for v1.1.

@nvkelso nvkelso added this to the v1.1.0 milestone Aug 25, 2016

@nvkelso nvkelso modified the milestones: v1.1.0, v1.2.0 Oct 5, 2016

@nvkelso nvkelso modified the milestones: v1.2.0, v1.1.0 Dec 28, 2016

@nvkelso nvkelso modified the milestones: v1.6.0, v1.7.0 Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment