New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle repeat on/off #21

Closed
fenryxo opened this Issue Nov 10, 2014 · 15 comments

Comments

4 participants
@fenryxo
Member

fenryxo commented Nov 10, 2014

Integrate player action toggle repeat on/off

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@fenryxo fenryxo added the priority low label Mar 4, 2015

@fenryxo fenryxo removed the priority low label Nov 15, 2016

@fenryxo fenryxo closed this Feb 6, 2017

@wafflebot wafflebot bot removed the postponed label Feb 6, 2017

@fenryxo fenryxo reopened this Feb 6, 2017

@fenryxo fenryxo removed the wishlist label Jun 18, 2018

fenryxo added a commit that referenced this issue Sep 10, 2018

Add API for Toggle repeat on/off
Issue: #21

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>

fenryxo added a commit to tiliado/nuvolasdk that referenced this issue Sep 13, 2018

Make the repeat button interactive
Issue: tiliado/nuvolaruntime#21

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>

fenryxo added a commit that referenced this issue Sep 13, 2018

Fix setting repeat status from MPRIS
Property change notification was not sent.

Issue: #21

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>

fenryxo added a commit that referenced this issue Sep 14, 2018

Add JS documentation for repeat status
Issue: #21

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>

fenryxo added a commit to tiliado/nuvola-app-deezer that referenced this issue Sep 15, 2018

Integrate repeat status
Issue: tiliado/nuvolaruntime#21

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo

fenryxo Sep 15, 2018

Member

Hello @a-m-s, @bors-ltd, and @d-r-q. Could you integrate the repeat status if it is relevant to your scripts? You need up-to-date Nuvola ADK >= 4.12.86. Also, don't forget to raise api_major/api_minor in metadata.in.json to 4/13. Thanks!

Member

fenryxo commented Sep 15, 2018

Hello @a-m-s, @bors-ltd, and @d-r-q. Could you integrate the repeat status if it is relevant to your scripts? You need up-to-date Nuvola ADK >= 4.12.86. Also, don't forget to raise api_major/api_minor in metadata.in.json to 4/13. Thanks!

fenryxo added a commit to tiliado/nuvola-app-spotify that referenced this issue Sep 16, 2018

Integrate repeat status
Issue: tiliado/nuvolaruntime#21

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>

fenryxo added a commit to tiliado/nuvola-app-soundcloud that referenced this issue Sep 16, 2018

Integrate repeat status
Issue: tiliado/nuvolaruntime#21

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>

fenryxo added a commit to tiliado/nuvola-app-google-play-music that referenced this issue Sep 16, 2018

Integrate repeat status
Issue: tiliado/nuvolaruntime#21

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@a-m-s

This comment has been minimized.

Show comment
Hide comment
@a-m-s

a-m-s Sep 17, 2018

Amazon Music is done. The others don't have a repeat feature.

a-m-s commented Sep 17, 2018

Amazon Music is done. The others don't have a repeat feature.

fenryxo added a commit that referenced this issue Sep 17, 2018

Add MediaPlayer.setCanRepeat/setRepeatState
Issue: #21

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>

fenryxo added a commit to tiliado/nuvolasdk that referenced this issue Sep 17, 2018

Switch to MediaPlayer.setCanRepeat/setRepeatState
Issue: tiliado/nuvolaruntime#21

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@d-r-q

This comment has been minimized.

Show comment
Hide comment
@d-r-q

d-r-q Sep 18, 2018

Yandex.Music don't support repeat

d-r-q commented Sep 18, 2018

Yandex.Music don't support repeat

@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo

fenryxo Sep 18, 2018

Member

Amazon Music is done. The others don't have a repeat feature.

Thanks :-) I've added a few inline comments to address: tiliado/nuvola-app-amazon-cloud-player@74fa997

Member

fenryxo commented Sep 18, 2018

Amazon Music is done. The others don't have a repeat feature.

Thanks :-) I've added a few inline comments to address: tiliado/nuvola-app-amazon-cloud-player@74fa997

@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo

fenryxo Sep 18, 2018

Member

Yandex.Music don't support repeat

Hello @d-r-q. There seems to be a repeat button in the bottom right corner (next to the volume button) on your screenshot. Was it removed? Or what's its functionality?

Member

fenryxo commented Sep 18, 2018

Yandex.Music don't support repeat

Hello @d-r-q. There seems to be a repeat button in the bottom right corner (next to the volume button) on your screenshot. Was it removed? Or what's its functionality?

@d-r-q

This comment has been minimized.

Show comment
Hide comment
@d-r-q

d-r-q Sep 19, 2018

Oh, I'm blind... Integrate it later this week.

d-r-q commented Sep 19, 2018

Oh, I'm blind... Integrate it later this week.

fenryxo added a commit to tiliado/nuvola-app-plex that referenced this issue Sep 21, 2018

fenryxo added a commit to tiliado/nuvola-app-owncloud-music that referenced this issue Sep 21, 2018

Integrate repeat status
Issue: tiliado/nuvolaruntime#21

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo

fenryxo Sep 21, 2018

Member

Currently completed repeat integrations will be announced on Sunday, September 23rd. The rest with Nuvola 4.13.0 (#472) or later when implemented.

Member

fenryxo commented Sep 21, 2018

Currently completed repeat integrations will be announced on Sunday, September 23rd. The rest with Nuvola 4.13.0 (#472) or later when implemented.

d-r-q pushed a commit to d-r-q/nuvola-app-yandex-music that referenced this issue Sep 23, 2018

Aleksey Zhidkov
Integrate repeat status
Issue: tiliado/nuvolaruntime#21

Signed-off-by: Aleksey Zhidkov <aleksey.zhidkov@pm.me>

d-r-q pushed a commit to d-r-q/nuvola-app-yandex-music that referenced this issue Sep 23, 2018

Aleksey Zhidkov
Integrate repeat status
Issue: tiliado/nuvolaruntime#21

Signed-off-by: Aleksey Zhidkov <aleksey.zhidkov@pm.me>
@d-r-q

This comment has been minimized.

Show comment
Hide comment
@d-r-q

d-r-q Sep 23, 2018

Hi @fenryxo, I've added support for repeat (and shuffle), but I'm little confused with current release process. Should I create an issue and/or pull request for this changes? And should I update changelog file?

d-r-q commented Sep 23, 2018

Hi @fenryxo, I've added support for repeat (and shuffle), but I'm little confused with current release process. Should I create an issue and/or pull request for this changes? And should I update changelog file?

bors-ltd pushed a commit to tiliado/nuvola-app-qobuz that referenced this issue Sep 23, 2018

@bors-ltd

This comment has been minimized.

Show comment
Hide comment
@bors-ltd

bors-ltd Sep 23, 2018

Added both repeat a track and the whole playlist to Qobuz.

Updated the changelog, ready for release.

I forgot to mention this on the shuffle issue but for some reason, the functions setCanShuffle and setCanRepeat were not available, though I used what I think is the latest SDK 4.12.92. So I used the "low-level" ones from the first announce. It won't make a difference for users.

bors-ltd commented Sep 23, 2018

Added both repeat a track and the whole playlist to Qobuz.

Updated the changelog, ready for release.

I forgot to mention this on the shuffle issue but for some reason, the functions setCanShuffle and setCanRepeat were not available, though I used what I think is the latest SDK 4.12.92. So I used the "low-level" ones from the first announce. It won't make a difference for users.

@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo

fenryxo Sep 24, 2018

Member

I've added support for repeat (and shuffle), but I'm little confused with current release process. Should I create an issue and/or pull request for this changes? And should I update changelog file?

Hello @d-r-q. The current release process needs to be documented, because the one in docs predates the switch to Flatpak builds. It works roughly this way:

  • Always update the changelog, but don't touch version numbers in metadata.in.json.
  • If you wish to have a code review, create a pull request to the master branch.
  • If you don't need a code review, commit directly to the master branch (@a-m-s does that).
  • Whatever is in the master branch is included in the next rebuild of Flatpaks.
  • Once for a while, I make a new X.Y.0 release of Nuvola and all components for third-party packagers. That's when the version_minor field gets updated.
Member

fenryxo commented Sep 24, 2018

I've added support for repeat (and shuffle), but I'm little confused with current release process. Should I create an issue and/or pull request for this changes? And should I update changelog file?

Hello @d-r-q. The current release process needs to be documented, because the one in docs predates the switch to Flatpak builds. It works roughly this way:

  • Always update the changelog, but don't touch version numbers in metadata.in.json.
  • If you wish to have a code review, create a pull request to the master branch.
  • If you don't need a code review, commit directly to the master branch (@a-m-s does that).
  • Whatever is in the master branch is included in the next rebuild of Flatpaks.
  • Once for a while, I make a new X.Y.0 release of Nuvola and all components for third-party packagers. That's when the version_minor field gets updated.
@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo

fenryxo Sep 24, 2018

Member

Added both repeat a track and the whole playlist to Qobuz.

Updated the changelog, ready for release.

Great, I rebuilt Qobuz flatpak today in the morning so your changes are live :-)

I forgot to mention this on the shuffle issue but for some reason, the functions setCanShuffle and setCanRepeat were not available, though I used what I think is the latest SDK 4.12.92. So I used the "low-level" ones from the first announce. It won't make a difference for users.

That's strange. Are you sure that nuvolaruntime --version said 4.12.92? If you are in a Bash session of Nuvola ADK and you update the ADK flatpak, the old flatpak is still in use until all its instances exit. (This way, it won't happen that a running flatpaked app crashes because its data files have suddenly changed because of a pending update.)

Member

fenryxo commented Sep 24, 2018

Added both repeat a track and the whole playlist to Qobuz.

Updated the changelog, ready for release.

Great, I rebuilt Qobuz flatpak today in the morning so your changes are live :-)

I forgot to mention this on the shuffle issue but for some reason, the functions setCanShuffle and setCanRepeat were not available, though I used what I think is the latest SDK 4.12.92. So I used the "low-level" ones from the first announce. It won't make a difference for users.

That's strange. Are you sure that nuvolaruntime --version said 4.12.92? If you are in a Bash session of Nuvola ADK and you update the ADK flatpak, the old flatpak is still in use until all its instances exit. (This way, it won't happen that a running flatpaked app crashes because its data files have suddenly changed because of a pending update.)

@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo

fenryxo Sep 24, 2018

Member
Member

fenryxo commented Sep 24, 2018

@bors-ltd

This comment has been minimized.

Show comment
Hide comment
@bors-ltd

bors-ltd Sep 24, 2018

Here is the output:

$ nuvola-adk
bash-4.3$ nuvolaruntime --version
Qobuz script
Version: 1.1.3
Revision: 3-gca69c9a
Maintainer: Bors, Ltd

--- Powered by ---

Nuvola Apps - Genuine flatpak build
Version 4.12.92
Revision 92-gbe08264
Diorite 4.12.24
WebKitGTK 2.20.2
Chromium 68.0.3440.75
libsoup 2.62.1

I'm sure no ADK session was open when I updated. I'll try again when updating to 4.13.0.

bors-ltd commented Sep 24, 2018

Here is the output:

$ nuvola-adk
bash-4.3$ nuvolaruntime --version
Qobuz script
Version: 1.1.3
Revision: 3-gca69c9a
Maintainer: Bors, Ltd

--- Powered by ---

Nuvola Apps - Genuine flatpak build
Version 4.12.92
Revision 92-gbe08264
Diorite 4.12.24
WebKitGTK 2.20.2
Chromium 68.0.3440.75
libsoup 2.62.1

I'm sure no ADK session was open when I updated. I'll try again when updating to 4.13.0.

@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo

fenryxo Oct 15, 2018

Member

Hello @bors-ltd, could you check whether your issue persists with Nuvola ADK 4.13.0? If yes, please create a new ticket for that. Thanks.

Member

fenryxo commented Oct 15, 2018

Hello @bors-ltd, could you check whether your issue persists with Nuvola ADK 4.13.0? If yes, please create a new ticket for that. Thanks.

@fenryxo

This comment has been minimized.

Show comment
Hide comment
@fenryxo
Member

fenryxo commented Oct 15, 2018

@fenryxo fenryxo closed this Oct 15, 2018

@wafflebot wafflebot bot removed the status: to release label Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment