This repository has been archived by the owner on Jun 13, 2019. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moved cron parsing logic into a library * exit early from provider code to avoid large if/else * todo: * test (this is just a WIP) * discuss this approach * add a test to confirm parsing works as expected
|
||
cron_d cron_name do | ||
action :create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would take this even further and add:
module EasyBib
module Cron
module Entry
def hour, minute, day, month, weekday, command
end
end
end
What do you think?
@fh Let me know what you think, one thing I cannot figure out right now is a loading issue. The class is not found in the provider, but this seems to work otherwise. |
This one works for me, at least the tests seem to be fine. Feel free to merge when you are satisfied, too :) |
Fixes the following error in a chef-run: DEBUG: LocalJumpError: easybib_crontab[gearmanworker] had an error: LocalJumpError: unexpected return
Return with next, because Ruby.
…break when no crontab is present cc @fh
@fh last test will break the build, let me know if you can check it out. |
@till Just did, see xmpp :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EasyBib::Cron::Entry