Skip to content

analytics: disable tilt analytics when DO_NOT_TRACK=1, CI=1 #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

analytics: disable tilt analytics when DO_NOT_TRACK=1, CI=1 #2878

merged 1 commit into from
Jan 30, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Jan 30, 2020

Hello @jazzdan,

Please review the following commits I made in branch nicks/ch3992/dnt:

3f73115 (2020-01-30 12:23:37 -0500)
analytics: disable tilt analytics when DO_NOT_TRACK=1, CI=1

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from jazzdan January 30, 2020 17:23
@nicks nicks force-pushed the nicks/ch3992/dnt branch 3 times, most recently from 8f328b7 to f2ab322 Compare January 30, 2020 18:00
@nicks nicks force-pushed the nicks/ch3992/dnt branch 3 times, most recently from 7bd8c3e to 3f00a2c Compare January 30, 2020 18:55
@nicks nicks merged commit b53c4c8 into master Jan 30, 2020
@nicks nicks deleted the nicks/ch3992/dnt branch January 30, 2020 19:36
@astrojuanlu astrojuanlu mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazzdan jazzdan jazzdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicks @jazzdan