Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluidsynth2 #101

Closed
wants to merge 5 commits into from
Closed

Fluidsynth2 #101

wants to merge 5 commits into from

Conversation

@swesterfeld
Copy link
Collaborator

@swesterfeld swesterfeld commented Apr 12, 2019

This updates the fluidsynth code to fluidsynth >= 2.0.0. This is not backward compatible, BEAST will not build against fluidsynth 1 any longer. The soundfont audio test reference file had to be updated due to a bugfix in fluidsynth 1 related to voice panning.

swesterfeld added 5 commits Apr 9, 2019
This fixes compilation if libbse dependency library headers are not in system
dirs.

Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
The voice panning code is slighlty buggy in old fluidsynth versions (for
instance 1.1.11). New fluidsynth >= 2.0.0 fix the bug, so we need to
update the reference file.

Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
@swesterfeld
Copy link
Collaborator Author

@swesterfeld swesterfeld commented Apr 14, 2019

One remark about us using the deprecated fluid_nwrite_float() function: if I use the non-deprecated version, our soundfont audio unit test fails. And things start sounding somewhat crappy. Turns out that the new replacement function is buggy, and we trigger this. I submitted a fix to upstream.

FluidSynth/fluidsynth#527

But since it will take time until this propagates into official fluidsynth releases I recommend staying with the old deprecated API for some time.

@tim-janik tim-janik closed this in 4c65148 Apr 15, 2019
@tim-janik tim-janik deleted the fluidsynth2 branch Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant