Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluidsynth2 #101

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
1 participant
@swesterfeld
Copy link
Collaborator

commented Apr 12, 2019

This updates the fluidsynth code to fluidsynth >= 2.0.0. This is not backward compatible, BEAST will not build against fluidsynth 1 any longer. The soundfont audio test reference file had to be updated due to a bugfix in fluidsynth 1 related to voice panning.

swesterfeld added some commits Apr 9, 2019

BSE: Makefile.mk: use correct compiler flags for building libbse
This fixes compilation if libbse dependency library headers are not in system
dirs.

Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
BSE: SF2: port soundfont support to fluidsynth2 API
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
config-checks.mk: require fluidsynth >= 2.0.0
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
BSE: SF2: adapt fluidsynth settings to fluidsynth 2 constraints
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
TESTS: audio: adapt soundfont test reference file to fluidsynth2
The voice panning code is slighlty buggy in old fluidsynth versions (for
instance 1.1.11). New fluidsynth >= 2.0.0 fix the bug, so we need to
update the reference file.

Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
@swesterfeld

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 14, 2019

One remark about us using the deprecated fluid_nwrite_float() function: if I use the non-deprecated version, our soundfont audio unit test fails. And things start sounding somewhat crappy. Turns out that the new replacement function is buggy, and we trigger this. I submitted a fix to upstream.

FluidSynth/fluidsynth#527

But since it will take time until this propagates into official fluidsynth releases I recommend staying with the old deprecated API for some time.

@tim-janik tim-janik closed this in 4c65148 Apr 15, 2019

@tim-janik tim-janik deleted the swesterfeld:fluidsynth2 branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.