Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track primitive properties ported to C++ #109

Closed
wants to merge 8 commits into from

Conversation

swesterfeld
Copy link
Collaborator

@swesterfeld swesterfeld commented Jul 28, 2019

I've ported all Track properties to C++ that do not contain object references. Two things are worth mentioning.

  1. Const MIDI_MAX_CHANNEL - I declared this as constant, but maybe the definition must be moved elsewhere. It seems to be required in bsebasics.idl, too (there is a // FIXME: MAX_MIDI_CHANNEL in the MidiChannelEvent definition)
  2. I didn't touch "signal::property-notify::n-voices" and similar signal code in bsttrackview.cc, I'm not sure what the C++ property equivalent would be

swesterfeld added 7 commits Jul 28, 2019
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
…ties

Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
@swesterfeld
Copy link
Collaborator Author

@swesterfeld swesterfeld commented Aug 5, 2019

I didn't touch "signal::property-notify::n-voices" and similar signal code

Update: I ported this to C++ now using track.on("notify:n_voices",...) for the new properties.

Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
GtkWidget *repeat_toggle;
BstItemView parent_object;
Bse::SongS song;
std::map<SfiProxy, Bse::TrackS> track_map;
Copy link
Owner

@tim-janik tim-janik Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, I'm perfectly happy with adding type aliases for complex types, so you don't need to reformat all members. E.g.

using TrackMap = std::map<SfiProxy, Bse::TrackS>;
// other members...
TrackMap    track_map;

@tim-janik tim-janik closed this in 223623e Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants