Repository navigation
Track primitive properties ported to C++ - #109
Closed
swesterfeld wants to merge 8 commits into
Closed
swesterfeld wants to merge 8 commits into
swesterfeld wants to merge 8 commits into
Conversation
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
…ties Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Collaborator
Author
Update: I ported this to C++ now using |
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
tim-janik
reviewed
Aug 8, 2019
| GtkWidget *repeat_toggle; | ||
| BstItemView parent_object; | ||
| Bse::SongS song; | ||
| std::map<SfiProxy, Bse::TrackS> track_map; |
Owner
There was a problem hiding this comment.
Note, I'm perfectly happy with adding type aliases for complex types, so you don't need to reformat all members. E.g.
using TrackMap = std::map<SfiProxy, Bse::TrackS>;
// other members...
TrackMap track_map;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've ported all Track properties to C++ that do not contain object references. Two things are worth mentioning.
Const MIDI_MAX_CHANNEL- I declared this as constant, but maybe the definition must be moved elsewhere. It seems to be required in bsebasics.idl, too (there is a// FIXME: MAX_MIDI_CHANNELin theMidiChannelEventdefinition)"signal::property-notify::n-voices"and similar signal code in bsttrackview.cc, I'm not sure what the C++ property equivalent would be