Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item properties ported to C++ #115

Closed
wants to merge 2 commits into from

Conversation

@swesterfeld
Copy link
Collaborator

swesterfeld commented Aug 8, 2019

Actually this is just one property: seqid

Since no more properties remain, I wonder if I should add a commit which removes the setter/getter (in this case bse_item_set|get_property_internal).

swesterfeld added 2 commits Aug 8, 2019
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
@tim-janik

This comment has been minimized.

Copy link
Owner

tim-janik commented Aug 8, 2019

Actually this is just one property: seqid

Since no more properties remain, I wonder if I should add a commit which removes the setter/getter (in this case bse_item_set|get_property_internal).

Haven't reviewed yet, but yes, that sounds like a good plan.

@tim-janik tim-janik closed this in a48588c Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.