Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix af-tests/soundfont-test on bionic #42
Soundfont audio tests are currently failing on bionic (18.04). As suggested here:
I propose a fix that
I was able to find the corresponding fluidsynth changelog entry, which is (fluidsynth 1.1.7):
which suggests that the new behaviour is caused by a bugfix.
Hi Stefan, thanks for the PR.
Overall it looks good, there's one thing that can be improved though.
a) Change configure.ac's FLUID_THRESHOLD to a FLUID_RELAXED_THRESHOLD boolean and pick the threshold inside the Makefile based on the boolean.
b) Change configure.ac's FLUID_THRESHOLD to FLUID_VERSION and pick a threshold inside the Makefile based on FLUID_VERSION>=1.1.7.
I guess (a) suffices for now, but (b) would be more future proof in case we have to adjust the threshold ever again. Come to think of it, we could run into future problems with other libraries as well. Scattering the threshold and version checks across Makefile.sub and configure.ac for each should be avoided. I.e. I'd merge either (a) or (b), but have a slight preference for (b) in terms of setting a precedent for future patches.