Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Port property Song::loop_enabled to C++ #64
Please merge. I ported and tested this property port.
Remarks: I tried and failed to use something like (doesn't compile).
Everything works as it is, but this would catch typos. In any case, it is not a big problem.
Hi Stefan, looks interesting.
I think I would have kept using iview->container plus a few more casts instead of introducing BstTrackView.song, to ensure that iview->container and BstTrackView.song cannot get out of sync.
There's one other bit missing though. WIth the old proxy interface, signal connections always come in (connect+disconnect) pairs, I'll quote the relevant code lines:
Before your PR:
After your PR:
I.e. you have replaced proxy_connect() with on(), added an event handler disconnect via =NULL but forgot to remove the proxy_disconnect line for track_view_repeat_changed that belongs to the proxy_connect() you removed.
Also please reword "/* disconnect */" to be more explicit: "// disconnects event handlers"
Not sure if you wanted the fixes in an extra commit (I did this) or squashed into the previous commit and delivered as non-linear push.