Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Song::loop_left property #65

Closed

Conversation

@swesterfeld
Copy link
Collaborator

@swesterfeld swesterfeld commented Aug 23, 2018

One more property C++ified.

swesterfeld added 2 commits Aug 24, 2018
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
@swesterfeld swesterfeld force-pushed the pport-song-loop-left branch from b627d8f to 14828cc Aug 24, 2018
…ties

Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
@swesterfeld
Copy link
Collaborator Author

@swesterfeld swesterfeld commented Aug 24, 2018

After the constant parsing was fixed in master, I rebased and updated this branch to now use SKIP_DEFAULT/SKIP_UNDO.

@tim-janik
Copy link
Owner

@tim-janik tim-janik commented Aug 26, 2018

Thanks for the PR, a couple comments:

> +      SfiInt lleft = self->song.loop_left();

Use just int, float, etc in new code, instead of gint or SfiInt.

> +  BseSong *self = const_cast<SongImpl*> (this)->as<BseSong *>();

This should be "as<BseSong*>", without the extra space.

> +      bool loop_enabled = self->loop_enabled_SL;

You're saving an old value here for comparing later. There's no need to keep this a variable, i.e. please make that const in similar code in the future:

+      const bool loop_enabled = self->loop_enabled_SL;

@tim-janik tim-janik closed this in 626efb2 Aug 26, 2018
@swesterfeld swesterfeld deleted the pport-song-loop-left branch Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants