New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Song::loop_right, Song::tick_pointer #68

Merged
merged 4 commits into from Aug 28, 2018

Conversation

Projects
None yet
2 participants
@swesterfeld
Copy link
Collaborator

swesterfeld commented Aug 27, 2018

2 more properties ported to C++

swesterfeld added some commits Aug 27, 2018

BSE: Song::loop_right: port property to C++
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
BEAST-GTK: use C++ property Song::loop_right
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
BSE: Song::tick_pointer: port property to C++
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
BEAST-GTK: use C++ property Song::tick_pointer
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
@tim-janik
Copy link
Owner

tim-janik left a comment

Thanks a lot, minor comments inline.

for (SfiRing *ring = self->tracks_SL; ring; ring = sfi_ring_walk (ring, self->tracks_SL))
{
BseTrack *track = (BseTrack*) ring->data;
track->track_done_SL = FALSE; /* let sequencer recheck if playing */

This comment has been minimized.

@tim-janik

tim-janik Aug 28, 2018

Owner

While you're at it, the C macros TRUE and FALSE should be converted to C++'s true and false.

@@ -565,7 +565,8 @@ pointer_move (BstTrackRollController *self,
drag->type != GXK_DRAG_DONE) /* skip release events */
{
guint tick = bst_track_roll_controller_quantize (self, drag->current_tick);
bse_proxy_set (self->song, "tick-pointer", tick, NULL);
Bse::SongH song = Bse::SongH::down_cast (bse_server.from_proxy (self->song));

This comment has been minimized.

@tim-janik

tim-janik Aug 28, 2018

Owner

It might (soon) be time to convert self->song into a scoped handle. Please keep an eye on when it's easier or not too much effort to use a Bse::SongS in the track controller and go for it, so we can avoid all those from_proxy down casts.

@tim-janik tim-janik merged commit 5de1c36 into tim-janik:master Aug 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

tim-janik added a commit that referenced this pull request Aug 28, 2018

Merge branch 'swesterfeld-song-merge', closes #68
* swesterfeld-song-merge:
  BEAST-GTK: use C++ property Song::tick_pointer
  BSE: Song::tick_pointer: port property to C++
  BEAST-GTK: use C++ property Song::loop_right
  BSE: Song::loop_right: port property to C++

Signed-off-by: Tim Janik <timj@gnu.org>

@swesterfeld swesterfeld deleted the swesterfeld:pport-song-merge branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment