Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Song::loop_right, Song::tick_pointer #68

Merged
merged 4 commits into from Aug 28, 2018

Conversation

@swesterfeld
Copy link
Collaborator

@swesterfeld swesterfeld commented Aug 27, 2018

2 more properties ported to C++

swesterfeld added 4 commits Aug 27, 2018
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Copy link
Owner

@tim-janik tim-janik left a comment

Thanks a lot, minor comments inline.

for (SfiRing *ring = self->tracks_SL; ring; ring = sfi_ring_walk (ring, self->tracks_SL))
{
BseTrack *track = (BseTrack*) ring->data;
track->track_done_SL = FALSE; /* let sequencer recheck if playing */
Copy link
Owner

@tim-janik tim-janik Aug 28, 2018

While you're at it, the C macros TRUE and FALSE should be converted to C++'s true and false.

@@ -565,7 +565,8 @@ pointer_move (BstTrackRollController *self,
drag->type != GXK_DRAG_DONE) /* skip release events */
{
guint tick = bst_track_roll_controller_quantize (self, drag->current_tick);
bse_proxy_set (self->song, "tick-pointer", tick, NULL);
Bse::SongH song = Bse::SongH::down_cast (bse_server.from_proxy (self->song));
Copy link
Owner

@tim-janik tim-janik Aug 28, 2018

It might (soon) be time to convert self->song into a scoped handle. Please keep an eye on when it's easier or not too much effort to use a Bse::SongS in the track controller and go for it, so we can avoid all those from_proxy down casts.

@tim-janik tim-janik merged commit 5de1c36 into tim-janik:master Aug 28, 2018
1 check passed
tim-janik added a commit that referenced this issue Aug 28, 2018
* swesterfeld-song-merge:
  BEAST-GTK: use C++ property Song::tick_pointer
  BSE: Song::tick_pointer: port property to C++
  BEAST-GTK: use C++ property Song::loop_right
  BSE: Song::loop_right: port property to C++

Signed-off-by: Tim Janik <timj@gnu.org>
@swesterfeld swesterfeld deleted the pport-song-merge branch Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants