Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSE: bseitem: fix undo resolve crash #77

Closed
wants to merge 1 commit into from

Conversation

@swesterfeld
Copy link
Collaborator

@swesterfeld swesterfeld commented Sep 3, 2018

Fix undo for Song::numerator (and others), which causes a crash (fatal error) after clang related updates.

Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
@tim-janik
Copy link
Owner

@tim-janik tim-janik commented Sep 9, 2018

Thanks a lot Stefan, good catch!
I'd be happy if you reviewed my other changes as well, i.e. what the diffs between branch merges give you:

git log -p --first-parent

You'd have to skip the odd po/* diff though, not sure if git log can filter that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants