New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timber::get_calling_script_file backtrace doesn't necessarily reference a file #785

Closed
gwagroves opened this Issue Dec 11, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@gwagroves
Contributor

gwagroves commented Dec 11, 2015

https://github.com/jarednova/timber/blob/master/timber.php#L608

The if clause assumes that the file key exists, but file is only a possible key. (A callable is listed in the backtrace without file being set, causing an undefined index notice to be triggered.)

Solution: use array_key_exists.

gwagroves added a commit to gwafork/timber that referenced this issue Dec 11, 2015

@prisis prisis referenced this issue Dec 16, 2015

Closed

New release :) #796

@connorjburton

This comment has been minimized.

Show comment
Hide comment
@connorjburton

connorjburton Feb 22, 2016

Contributor

Closing as this has been merged.

Contributor

connorjburton commented Feb 22, 2016

Closing as this has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment