Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The `json_parser` `drop_field` option should only drop the field on successful parsing #1861

Closed
binarylogic opened this issue Feb 19, 2020 · 0 comments

Comments

@binarylogic
Copy link
Member

@binarylogic binarylogic commented Feb 19, 2020

From our chat:

I have another quick question - the json_parser transform seems to always remove the source field when drop_field is true. This seems inconsistent with the behavior of e.g. grok_parser, which only removes it when the parse succeeds. Is that behavior intentional?

We should not be dropping the field is parsing fails.

Related #1172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.