Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Ubuntu parse_timestamp test failures #551

Closed
LucioFranco opened this issue Jul 1, 2019 · 7 comments

Comments

@LucioFranco
Copy link
Member

commented Jul 1, 2019

In the process of updating our release process, @binarylogic had switched our main builder container for running the test-stable build from a Debian based container to a ubuntu one. This caused three local timestamp parsing tests to fail locally. These are the tests that were added from #542 that were originally causing issues and were fixed via adding this line. They seem to be reoccurring on ubuntu only now. Temp solution has been to move back to a debian based container #550.

We need to evaluate what effect this may have on our users who run vector on ubuntu and what additional steps a contributor using ubuntu must do to get the tests working locally.

@bruceg

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

I've tried running the tests on my Ubuntu laptop, and they pass for me. Is there an easy way of reproducing them? What is the failure message? The exact values reported by assert_eq! should show what failed with the conversion (at least, I assume that's where it's failing).

@LucioFranco

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

@bruceg were you able to reproduce using this container at all? timberiodev/vector-tester:latest

@lukesteensen

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

I develop on Ubuntu almost exclusively and I don't think I've ever seen one of these failures.

@bruceg

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

I was able to reproduce with the provided container. However, that container is missing the time zone data files. After installing the tzdata package, these tests pass. I think that makes it a problem with the container and not the sources, as having time zone data installed is required for any kind of zone-aware conversions.

@LucioFranco

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2019

Does this sound like something that could be useful to be documented?

@bruceg

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

It would be good to mention something about it. I see the Alpine Linux base image for Docker has no zoneinfo files installed, so it won't be as uncommon a configuration issue as I thought.

@binarylogic

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

I added a note here: https://docs.vector.dev/about/data-model/log#timestamp

Closing as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.