Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(config)!: Nest batch_* and request_* sink config options #1493

Merged
merged 13 commits into from Jan 12, 2020
Merged

chore(config)!: Nest batch_* and request_* sink config options #1493

merged 13 commits into from Jan 12, 2020

Conversation

LucioFranco
Copy link
Contributor

@LucioFranco LucioFranco commented Jan 8, 2020 •
edited

Closes #916, #1022, #1023 and #1090

@LucioFranco
feat(config): Nest tower request options
0b9976a 
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
@LucioFranco
feat(config): Nest batch config types
91e3ff5 
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
@LucioFranco LucioFranco requested a review from a user January 8, 2020 21:56
@LucioFranco
fmt
9e1ae95 
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
@LucioFranco LucioFranco added the needs: docs Needs documentation updates label Jan 8, 2020
@LucioFranco
fix tests
cc6432c 
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
@LucioFranco
Fix new relic logs config test
de8a645 
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
bruceg
bruceg approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@bruceg bruceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@LucioFranco
Copy link
Contributor Author

This is now updated to also fix #916

@binarylogic binarylogic removed request for loony-bean and a user January 12, 2020 17:56
LucioFranco and others added 3 commits January 12, 2020 13:10
@LucioFranco
Merge remote-tracking branch 'origin/master' into lucio/nest
0957d3e 
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
@LucioFranco
fmt
cf57d7e 
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
@binarylogic
Update docs
b7b811f
@binarylogic binarylogic removed the needs: docs Needs documentation updates label Jan 12, 2020
@binarylogic binarylogic changed the title feat(config): Nest batch and request sink config types chore(config)!: Nest batch_* and request_* sink config options Jan 12, 2020
LucioFranco and others added 2 commits January 12, 2020 14:18
@LucioFranco
Update default kinesis and firehose batch sizes
5a61446 
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
@binarylogic
Update max_events defaults
48f4935 
Signed-off-by: binarylogic <bjohnson@binarylogic.com>
@binarylogic binarylogic merged commit 6345f5f into master Jan 12, 2020
@binarylogic binarylogic deleted the lucio/nest branch January 12, 2020 19:31
@binarylogic
Copy link
Contributor

Just a heads up @LucioFranco , the "closes ..." syntax does not close all of the issues.

This was referenced Jan 22, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruceg bruceg bruceg approved these changes

@binarylogic binarylogic binarylogic approved these changes

@lukesteensen lukesteensen Awaiting requested review from lukesteensen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify batch_size terminology
4 participants
@LucioFranco @binarylogic @lukesteensen @bruceg