Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows platform): Correct lints and tests #1789

Merged
merged 2 commits into from Feb 15, 2020

Conversation

@Hoverbear
Copy link
Contributor

Hoverbear commented Feb 14, 2020

As reported in #1412 , Windows builds/tests have lints and errors.

This PR fixes all lints and tweaks a few tests to make it viable for Windows to pass.

  • Mark any unix only imports in #[cfg(unix)].
  • Windows errors if you try to rename a file into a path that already exists. So we now use a simple file rolling procedure in those tests.
  • Improves unwrap errors into expect errors to give some context to failing tests.
Signed-off-by: Ana Hobden <operator@hoverbear.org>
@Hoverbear Hoverbear self-assigned this Feb 14, 2020
@Hoverbear Hoverbear added this to In progress in Weekly Sprint (Feb 10, 2020) via automation Feb 14, 2020
@Hoverbear Hoverbear changed the title Fix windows builds fix(windows platform): Correct lints and tests Feb 14, 2020
Signed-off-by: Ana Hobden <operator@hoverbear.org>
@Hoverbear Hoverbear force-pushed the Hoverbear:windows-fixes branch from 1236b17 to ddd05bb Feb 14, 2020
Copy link
Member

lukesteensen left a comment

The joys of supporting multiple platforms 😬

lib/file-source/src/lib.rs Show resolved Hide resolved
Weekly Sprint (Feb 10, 2020) automation moved this from In progress to Reviewer approved Feb 14, 2020
@Hoverbear Hoverbear merged commit 5138513 into timberio:master Feb 15, 2020
13 checks passed
13 checks passed
cargo-deny
Details
Header rules Deploy canceled
Details
Mixed content Deploy canceled
Details
Pages changed Deploy canceled
Details
Redirect rules Deploy canceled
Details
DCO DCO
Details
Semantic Pull Request ready to be squashed
Details
ci/circleci: check-blog Your tests passed on CircleCI!
Details
ci/circleci: check-code Your tests passed on CircleCI!
Details
ci/circleci: check-fmt Your tests passed on CircleCI!
Details
ci/circleci: check-generate Your tests passed on CircleCI!
Details
ci/circleci: test-stable Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview canceled.
Details
Weekly Sprint (Feb 10, 2020) automation moved this from Reviewer approved to Done Feb 15, 2020
bednar added a commit to bonitoo-io/vector that referenced this pull request Feb 17, 2020
* Fix windows builds

Signed-off-by: Ana Hobden <operator@hoverbear.org>

* Remove deny(warnings)

Signed-off-by: Ana Hobden <operator@hoverbear.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.