enhancement(lua transform)!: respect Lua types when converting back to events #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectordotdev#857) This also slightly changes the behavior to drop fields when set to invalid values, rather than erroring out the function. Signed-off-by: Samuel Cormier-Iijima <samuel@cormier-iijima.com>
sciyoshi
force-pushed
the
lua-event-fields-respect-types
branch
from
1aedbbb
to
1ed6661
Compare
ghost
changed the title
ghost
merged commit 
|
I wonder if this can be updated to accept lua tables/arrays now that #704 is complete? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Lua transform with a function like this:
the resulting event has the value converted back to a string:
This PR changes the transform to preserve types, and also adds support for setting fields to boolean values, saving the need for further processing to restore the types. It also slightly changes the behavior to drop fields when set to invalid types, rather than erroring out the function. I'm not sure what impact this will have when it comes to #704, however.
Fixes #857.