New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: Add DataDog's distribution
metric
#2913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it confusing that a Distribution
can either be a Distribution
or a Histogram
when we also have a top level AggregatedHistogram
. Could you explain why we've modeled it this way? I didn't see anything obvious in the linked Datadog documentation.
@lukesteensen It has more to do with our code than DataDogs. The original
In the original version, the 2. part was calculating histogram. Since this new DataDog
Regarding naming scheme, I agree, it is confusing, the top level |
@lukesteensen |
4d58c78
to
5311c4c
Compare
5311c4c
to
f16f9fc
Compare
Moving forward, I think the best thing to do here is to accept the |
@lukesteensen what about extending this to |
@ktff That sounds like a good plan to me! |
38cdbb4
to
c67f68c
Compare
@binarylogic |
62e1def
to
5a7f220
Compare
@binarylogic @lukesteensen could you review this? This turned out more complex than anticipated so after merging this I'll update #2603 with a proper plan. I'm also unsure how to fix the |
5a7f220
to
855e88f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
Signed-off-by: ktf <krunotf@gmail.com>
855e88f
to
d866f67
Compare
* Add StatisticKind Signed-off-by: ktf <krunotf@gmail.com> * Update tests Signed-off-by: ktf <krunotf@gmail.com> * Update aws_cloudwatch_metrics sink Signed-off-by: ktf <krunotf@gmail.com> * Update lua transform Signed-off-by: ktf <krunotf@gmail.com> * Fix build Signed-off-by: ktf <krunotf@gmail.com> * Fix test Signed-off-by: ktf <krunotf@gmail.com> * Add test Signed-off-by: ktf <krunotf@gmail.com> * Update remaining usages of Distribution Signed-off-by: ktf <krunotf@gmail.com> * Update tests Signed-off-by: ktf <krunotf@gmail.com> * Rename to Samples Signed-off-by: ktf <krunotf@gmail.com> * Update test Signed-off-by: ktf <krunotf@gmail.com> * Rename stray Distribution Signed-off-by: ktf <krunotf@gmail.com> * Update statsd sink Signed-off-by: ktf <krunotf@gmail.com> * Update cherry picked Signed-off-by: ktf <krunotf@gmail.com> * Simpler naming Signed-off-by: ktf <krunotf@gmail.com> * Update docs Signed-off-by: ktf <krunotf@gmail.com> * Update Signed-off-by: ktf <krunotf@gmail.com> * Remove trailling space Signed-off-by: ktf <krunotf@gmail.com> * Remove unused Signed-off-by: ktf <krunotf@gmail.com> * Add new line Signed-off-by: ktf <krunotf@gmail.com> * Bump Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Ref. #2603
PR expands the following:
metric
scheme withsummary
metric by expandingMetricValue::Distribution
to haveStatisticKind
.statsd
source to acceptd
.statsd
sink to emitd
.Other sinks treat the new metric as
histogram
.Documentation
Minimal amount has been changed.
We could update documentation for metric sinks:
aws_cloudwatch_metrics
datadog_metrics
prometheus
influxdb_metrics
but I'm unsure if we would like to do it now in this state.
Naming
Instead of name
distribution
,summary
was chosen for clarity in context of ourmetric
scheme, andMetricValue::Distribution
was not renamed so to avoid breaking change.Todo
Use some other naming scheme?
Is changing
proto
a breaking change? (EDIT: in this case not)Documentation
Update website documentation.
Set timestamp to null in website documentation for
statsd
source ? (EDIT: They show the end result)Recheck existing docmentation.