feat(elasticsearch sink): Add HTTP Basic authorization #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruce Guenter <bruce@untroubled.org>
Signed-off-by: Bruce Guenter <bruce@untroubled.org>
binarylogic
reviewed
Aug 13, 2019
|
|
||
| let policy = FixedRetryPolicy::new( | ||
| retry_attempts, | ||
| Duration::from_secs(retry_backoff_secs), | ||
| HttpRetryLogic, | ||
| ); | ||
|
|
||
| let authorization = config.basic_auth.clone().map(|auth| { | ||
| let token = format!("{}:{}", auth.user, auth.password); | ||
| format!("Basic {}", base64::encode(token.as_bytes())) |
There was a problem hiding this comment.
I think this is correct, but wanted to make sure base64url is not required here instead.
There was a problem hiding this comment.
I don't believe so, since it's not going into the url.
There was a problem hiding this comment.
AFAIK the authorization token uses the standard base64 character set.
lukesteensen
approved these changes
Aug 13, 2019
|
|
||
| let policy = FixedRetryPolicy::new( | ||
| retry_attempts, | ||
| Duration::from_secs(retry_backoff_secs), | ||
| HttpRetryLogic, | ||
| ); | ||
|
|
||
| let authorization = config.basic_auth.clone().map(|auth| { | ||
| let token = format!("{}:{}", auth.user, auth.password); | ||
| format!("Basic {}", base64::encode(token.as_bytes())) |
There was a problem hiding this comment.
I don't believe so, since it's not going into the url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for HTTP Basic authorization to the elasticsearch sink.
Closes #472